Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(common-api): fix dependancies of common api on independantly build #14624

Merged
merged 1 commit into from
Dec 17, 2024
Merged

build(common-api): fix dependancies of common api on independantly build #14624

merged 1 commit into from
Dec 17, 2024

Conversation

tibs245
Copy link
Contributor

@tibs245 tibs245 commented Dec 17, 2024

Question Answer
Branch? master
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #NONE
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

@tibs245 tibs245 requested review from a team as code owners December 17, 2024 13:51
@tibs245 tibs245 self-assigned this Dec 17, 2024
@github-actions github-actions bot added dependencies Pull requests that update a dependency file build Changes that affect the build system or external dependencie labels Dec 17, 2024
anooparveti
anooparveti reviewed Dec 17, 2024
View reviewed changes
packages/manager/modules/common-api/package.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Package can be mentioned both in devDeps & peerDeps

@tibs245 tibs245 force-pushed the build/fix-common-api-dependancies branch from 5e53d92 to dc98e47 Compare December 17, 2024 14:24
@github-actions github-actions bot added build Changes that affect the build system or external dependencie and removed build Changes that affect the build system or external dependencie labels Dec 17, 2024
@tibs245 tibs245 force-pushed the build/fix-common-api-dependancies branch from dc98e47 to db2d2c1 Compare December 17, 2024 14:25
@github-actions github-actions bot added build Changes that affect the build system or external dependencie and removed build Changes that affect the build system or external dependencie dependencies Pull requests that update a dependency file labels Dec 17, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tibs245 tibs245 merged commit 5b42cb5 into master Dec 17, 2024
16 checks passed
@tibs245 tibs245 deleted the build/fix-common-api-dependancies branch December 17, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darsene darsene darsene approved these changes

@fredericvilcot fredericvilcot fredericvilcot approved these changes

@anooparveti anooparveti anooparveti approved these changes

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees

@tibs245 tibs245

Labels
build Changes that affect the build system or external dependencie
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tibs245 @anooparveti @fredericvilcot @darsene