Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(veeam-backup): display storage value using more explicit label #14629

Merged
merged 2 commits into from
Jan 7, 2025
Merged

feat(veeam-backup): display storage value using more explicit label #14629

merged 2 commits into from
Jan 7, 2025

Conversation

pauldkn
Copy link
Contributor

@pauldkn pauldkn commented Dec 17, 2024 •
edited
Loading

ref: MANAGER-16076

Question Answer
Branch? fix/MANAGER-16236
Bug fix? no
New feature? yes
Breaking change? no
Tickets feat/MANAGER-16076
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

Translation request :

  • CMT-19999

@pauldkn pauldkn requested review from a team as code owners December 17, 2024 16:12
@pauldkn pauldkn requested review from frenautvh and seven-amid and removed request for a team December 17, 2024 16:12
@pauldkn pauldkn requested a review from a team as a code owner December 18, 2024 13:51
@pauldkn pauldkn requested review from tibs245, MaximeBajeux and darsene and removed request for a team December 18, 2024 13:51
@pauldkn pauldkn changed the title feat(veeam-backup): display storage value using same unit feat(veeam-backup): display storage value using more explicit label Dec 18, 2024
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Dec 19, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Dec 19, 2024
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Dec 24, 2024
feat(veeam-backup): display storage value using same unit
dc6974a 
ref: MANAGER-16076

Signed-off-by: Paul Dickerson <[email protected]>
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Dec 24, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pauldkn pauldkn merged commit b07bfa0 into fix/MANAGER-16236 Jan 7, 2025
12 of 13 checks passed
@pauldkn pauldkn deleted the feat/MANAGER-16076 branch January 7, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjamet-ovh rjamet-ovh rjamet-ovh approved these changes

@tibs245 tibs245 tibs245 approved these changes

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid was automatically assigned from ovh/su-digital-tools-core-stack

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux was automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pauldkn @tibs245 @rjamet-ovh