Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(*): update tailwind config for third party imports #14675

Merged
merged 6 commits into from
Jan 3, 2025
Merged

fix(*): update tailwind config for third party imports #14675

merged 6 commits into from
Jan 3, 2025

Conversation

fredericvilcot
Copy link
Contributor

@fredericvilcot fredericvilcot commented Dec 19, 2024 •
edited
Loading

Question Answer
Branch? develop
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #...
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@fredericvilcot fredericvilcot changed the base branch from master to develop December 19, 2024 13:46
@github-actions github-actions bot added the bug Something isn't working label Dec 19, 2024
@aboungnaseng-ovhcloud aboungnaseng-ovhcloud force-pushed the fix/mrc-pci-common-tailwind-imports branch from 1aab12c to b6176fd Compare December 20, 2024 10:24
@fredericvilcot fredericvilcot marked this pull request as ready for review January 2, 2025 09:48
@fredericvilcot fredericvilcot requested review from frenautvh and a team as code owners January 2, 2025 09:48
@fredericvilcot fredericvilcot force-pushed the fix/mrc-pci-common-tailwind-imports branch from b6176fd to 063ba72 Compare January 2, 2025 11:11
@github-actions github-actions bot removed the common label Jan 2, 2025
@fredericvilcot fredericvilcot force-pushed the fix/mrc-pci-common-tailwind-imports branch from ecdceb5 to db603bd Compare January 2, 2025 11:16
@github-actions github-actions bot removed the container label Jan 2, 2025
Eric-ciccotti
Eric-ciccotti previously approved these changes Jan 2, 2025
View reviewed changes
ppprevost
ppprevost previously approved these changes Jan 2, 2025
View reviewed changes
anooparveti
anooparveti previously approved these changes Jan 2, 2025
View reviewed changes
@ovh-ux-cds
sync: master to develop
1051c9a 
sync: master to develop
@ovh-ux-cds
sync: master to develop
0d1b040 
sync: master to develop
@fredericvilcot fredericvilcot force-pushed the fix/mrc-pci-common-tailwind-imports branch from db603bd to a5edece Compare January 2, 2025 16:15
fredericvilcot and others added 4 commits January 2, 2025 17:21
@fredericvilcot fredericvilcot force-pushed the fix/mrc-pci-common-tailwind-imports branch from a5edece to b65ac13 Compare January 2, 2025 16:21
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@anooparveti anooparveti changed the base branch from develop to release/public-cloud-w1 January 3, 2025 07:44
@anooparveti anooparveti merged commit 717de9f into release/public-cloud-w1 Jan 3, 2025
17 checks passed
@anooparveti anooparveti deleted the fix/mrc-pci-common-tailwind-imports branch January 3, 2025 07:45
@anooparveti anooparveti mentioned this pull request Jan 3, 2025
Merged
8 tasks
anooparveti pushed a commit that referenced this pull request Jan 7, 2025
@fredericvilcot @aboungnaseng-ovhcloud @anooparveti
fix(*): update tailwind config for third party imports (#14675)
822f1bc 
ref: TAPC-2482

Signed-off-by: Frédéric Vilcot <[email protected]>
Co-authored-by: Alex Boungnaseng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anooparveti anooparveti anooparveti approved these changes

@Eric-ciccotti Eric-ciccotti Eric-ciccotti left review comments

@ppprevost ppprevost ppprevost left review comments

@frenautvh frenautvh Awaiting requested review from frenautvh

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 was automatically assigned from ovh/team-manager-dev-angularjs

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux was automatically assigned from ovh/team-manager-dev-angularjs

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn was automatically assigned from ovh/team-manager-dev-angularjs

Assignees

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud

Labels
bug Something isn't working universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fredericvilcot @ppprevost @anooparveti @Eric-ciccotti @aboungnaseng-ovhcloud @ovh-ux-cds