feat(ips): region selector #14687
Merged
feat(ips): region selector #14687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: MANAGER-15789 Signed-off-by: Nicolas Pierre-charles <[email protected]>
chipp972
requested review from
kqesar,
frenautvh,
qpavy,
ghyenne and
sachinrameshn
and removed request for
a team
github-actions
bot
added
translation required
dependencies
|
| Status | Count |
|---|---|
| 1 | |
| 7 | |
| 1 | |
| 2 |
Click to toggle table visibility
| Name | Status | Previous | Current |
|---|---|---|---|
@floating-ui/core |
1.6.5 | 1.6.8 | |
@floating-ui/dom |
1.6.3 | 1.6.11 | |
@floating-ui/utils |
0.2.5 | 0.2.8 | |
@ovhcloud/ods-components |
18.0.0 | 18.4.0 | |
@ovhcloud/ods-themes |
18.0.0 | 18.4.1 | |
@storybook/addon-a11y |
8.0.4 | - | |
@storybook/addon-highlight |
8.0.4 | 7.5.3 | |
@testing-library/jest-dom |
6.5.0 | 6.6.3 | |
@testing-library/react |
16.0.1 | 16.1.0 | |
axe-core |
4.10.0 | - | |
flag-icons |
- | 7.2.3 |
anooparveti
requested changes
Dec 20, 2024
There was a problem hiding this comment.
Most of the translations are already from MRC. Avoid duplicating them.
There was a problem hiding this comment.
Actually the region component does not provide these translations
The country and city names are in the same translation key so we can't use this component to implement the new region selector
anooparveti
requested changes
Dec 20, 2024
packages/manager/apps/ips/src/components/RegionSelector/RegionSelector.spec.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/ips/src/components/RegionSelector/regionSelector.utils.ts
Outdated
Show resolved
Hide resolved
chipp972
force-pushed
the
feat/ips-region-selector
branch
3 times, most recently
from
8573e22 to
77fa93e
Compare
qpavy
approved these changes
Dec 20, 2024
chipp972
force-pushed
the
feat/ips-region-selector
branch
6 times, most recently
from
22ce5c2 to
971944b
Compare
ref: MANAGER-16479 Signed-off-by: Nicolas Pierre-charles <[email protected]>
chipp972
force-pushed
the
feat/ips-region-selector
branch
from
971944b to
aef4bf2
Compare
|
mhelhali-soufien
approved these changes
Jan 9, 2025
chipp972
added a commit
that referenced
this pull request
Jan 20, 2025
ref: MANAGER-16479 Signed-off-by: Nicolas Pierre-charles <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project/ip-revampBreaking change is mentioned in relevant commitsDescription
Related