Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(container): add animations to pnr #14691

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat(container): add animations to pnr #14691

wants to merge 6 commits into from
+345 −167

Conversation

MaximeBajeux
Copy link
Contributor

Question Answer
Branch? master / release/** / develop
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets Fix #...
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

Maxime Bajeux added 3 commits December 17, 2024 16:51
feat(container): add animations to pnr
5a6052c 
Signed-off-by: Maxime Bajeux <[email protected]>
feat(container): add animations to pnr
e846a71 
ref: MANAGER-14461

Signed-off-by: Maxime Bajeux <[email protected]>
feat(container): merge with ods feedback and new icons
3957f33 
ref: MANAGER-14461

Signed-off-by: Maxime Bajeux <[email protected]>
@MaximeBajeux MaximeBajeux requested review from a team as code owners December 20, 2024 09:12
oalkabouss and others added 2 commits December 20, 2024 10:21
@oalkabouss
feat(container): animation improvement & add skeleton on entry menu (#…
d218477 
…13867)

ref: MANAGER-14921
Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
feat(container): add animations to PNR
cfb318a 
ref: MANAGER-14461

Signed-off-by: Maxime Bajeux <[email protected]>
feat(container): change spinner behavior
aea5653 
ref: MANAGER-14461

Signed-off-by: Maxime Bajeux <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesLarique JacquesLarique JacquesLarique approved these changes

@aottr aottr aottr approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
container feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaximeBajeux @aottr @JacquesLarique @oalkabouss