Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-load-balancer): [Load Balancer 3AZ] - Configuration page - Add 3-AZ tag #14692

Merged
merged 3 commits into from
Dec 20, 2024
Merged

feat(pci-load-balancer): [Load Balancer 3AZ] - Configuration page - Add 3-AZ tag #14692

merged 3 commits into from
Dec 20, 2024

Conversation

Tsiorifamonjena
Copy link
Contributor

@Tsiorifamonjena Tsiorifamonjena commented Dec 20, 2024 •
edited
Loading

Question Answer
Branch? feat/epic-TAPC-2304
Bug fix? no
New feature? yes
Breaking change? yes/no
Tickets Fix #TAPC-2270
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@Tsiorifamonjena Tsiorifamonjena requested review from a team as code owners December 20, 2024 10:23
@Tsiorifamonjena Tsiorifamonjena requested review from sidlynx and kqesar and removed request for a team December 20, 2024 10:23
@github-actions github-actions bot added the feature New feature label Dec 20, 2024
@Tsiorifamonjena
feat(pci.load-balancer): fix unit test
b44cfeb 
ref: TAPC-2270
Signed-off-by: tsiorifamonjena <[email protected]>
@Tsiorifamonjena Tsiorifamonjena changed the title feat(pic-load-balancer): [Load Balancer 3AZ] - Configuration page - Add 3-AZ tag feat(pci-load-balancer): [Load Balancer 3AZ] - Configuration page - Add 3-AZ tag Dec 20, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
13.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Tsiorifamonjena Tsiorifamonjena merged commit 83582cd into feat/epic-TAPC-2304 Dec 20, 2024
13 of 14 checks passed
@Tsiorifamonjena Tsiorifamonjena deleted the feat/pci-load-balancer_3AZ_tapc-2270 branch December 20, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Tsiorifamonjena