fix(mrc): fix <OnboardingLayout /> #14940
Open
+272
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjamet-ovh
requested review from
stif59100,
aboungnaseng-ovhcloud,
kqesar,
frenautvh,
MaximeBajeux,
anooparveti and
JacquesLarique
3 tasks
rjamet-ovh
force-pushed
the
fix/gh-14934
branch
from
a2759e4 to
1890ea6
Compare
chipp972
previously approved these changes
Jan 15, 2025
rjamet-ovh
force-pushed
the
fix/gh-14934
branch
from
1890ea6 to
2d1433d
Compare
darsene
reviewed
Jan 16, 2025
| /> | ||
| </div> | ||
| )} | ||
| <OdsText | ||
| preset={ODS_TEXT_PRESET.heading1} | ||
| className="block text-center sm:pt-8 xs:pt-2.5" | ||
| className="block text-center " |
There was a problem hiding this comment.
Niptick
Suggested change
| className="block text-center " | |
| className="block text-center" |
aboungnaseng-ovhcloud
previously approved these changes
Jan 16, 2025
added 2 commits
January 17, 2025 16:26
- more info: use <OdsButton /> - update css to match design specs ref: 14934 Signed-off-by: Romain Jamet <[email protected]>
ref: 14934 Signed-off-by: Romain Jamet <[email protected]>
rjamet-ovh
force-pushed
the
fix/gh-14934
branch
from
2d1433d to
32eefc4
Compare
|
darsene
approved these changes
Jan 17, 2025
anooparveti
requested changes
Jan 17, 2025
| {description} | ||
| </OdsText> | ||
| )} | ||
| {description} |
There was a problem hiding this comment.
nitpick: I think this can have adverse effect on existing apps if they dont pass description inside an OdsText.
IMO, OdsText must be retained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developOnly FR translations have been updatedBreaking change is mentioned in relevant commitsDescription
<OdsButton />