enh: 35% faster is_valid_ip #432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speed47
force-pushed
the
is_valid_ip
branch
4 times, most recently
from
95007dc to
d741847
Compare
deathiop
previously approved these changes
Dec 4, 2023
|
Not enough unit tests to my taste, to ensure there is no behavior change between this version and before, PR will stay as Draft until this is the case |
deathiop
previously approved these changes
Apr 17, 2024
When restricted commands need to be used during tests, we now use "account0" which has all these commands granted, instead of granting/revoking commands every time with no added value with respect to the tests. This was previously required for OSes that have a limit to the number of groups an account can be a member of, but these OSes have now long been unsupported.
This is slow and almost never catched a bug, so consistency check is still supported but will not run by default, as it is quite slow, checking the system between each and every test. The option --skip-consistency-check is now ignored, and a new option to enable it has been added: --consistency-check
…rs don't have access to
…en account doesn't have access to it
Remove 'partial_members' and 'full_members' from JSON output, which were replaced by 'members' and 'guests' since pre-v3.00.00
|
will reopen once rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.