ovn-tester: introduce ovn-ic #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorenzoBianconi
force-pushed
the
ovn-ic
branch
12 times, most recently
from
4db21d0 to
931c96d
Compare
LorenzoBianconi
changed the title
LorenzoBianconi
force-pushed
the
ovn-ic
branch
11 times, most recently
from
53b69bc to
9571f55
Compare
LorenzoBianconi
changed the title
LorenzoBianconi
force-pushed
the
ovn-ic
branch
3 times, most recently
from
dc42821 to
31ab73f
Compare
LorenzoBianconi
force-pushed
the
ovn-ic
branch
2 times, most recently
from
36f9ce2 to
2932cf3
Compare
dceara
reviewed
Sep 25, 2023
dceara
reviewed
Sep 27, 2023
dceara
reviewed
Sep 28, 2023
dceara
requested changes
Sep 28, 2023
LorenzoBianconi
force-pushed
the
ovn-ic
branch
3 times, most recently
from
6340665 to
4727b5b
Compare
LorenzoBianconi
force-pushed
the
ovn-ic
branch
from
4727b5b to
bd4433a
Compare
dceara
requested changes
Oct 19, 2023
There was a problem hiding this comment.
I have a few minor comments, with those addressed the rest looks good for now (we still need to add support for multiple central nodes but we can do that as a follow up).
We should also not forget to remove the commit that uses the private ovn-fake-multinode branch:
ovn-heater: rely on private ovn-fake-multinode for the moment
LorenzoBianconi
force-pushed
the
ovn-ic
branch
2 times, most recently
from
0755d07 to
2b965ca
Compare
This is a preliminary patch to add ovn-ic support to ovn-tester. Signed-off-by: Lorenzo Bianconi <[email protected]>
…ing multiple az Signed-off-by: Lorenzo Bianconi <[email protected]>
Signed-off-by: Lorenzo Bianconi <[email protected]>
Signed-off-by: Lorenzo Bianconi <[email protected]>
Signed-off-by: Lorenzo Bianconi <[email protected]>
Signed-off-by: Lorenzo Bianconi <[email protected]>
Signed-off-by: Lorenzo Bianconi <[email protected]>
Signed-off-by: Lorenzo Bianconi <[email protected]>
Signed-off-by: Lorenzo Bianconi <[email protected]>
Signed-off-by: Lorenzo Bianconi <[email protected]>
Signed-off-by: Lorenzo Bianconi <[email protected]>
dceara
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ovn-ic support to ovn-tester.