[WIP/RFC] Extract generic methods from WorkerNode and Cluster classes.
#175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnordahl
commented
Sep 14, 2023
ovn-tester/ovn_workload.py
Outdated
| raise NotImplemented | ||
|
|
||
|
|
||
| class WorkerNode(ChassisNode): |
There was a problem hiding this comment.
@dceara it is this inheritance that made me think of ChassisNode as Compute does not really fit with Kubernetes. Or what do you think?
There was a problem hiding this comment.
It could also serve as a base for a NetworkNode
There was a problem hiding this comment.
I'm ok with both; if ChassisNode makes more sense to you let's go with that. :)
fnordahl
force-pushed
the
ovn-workload-extract-generic
branch
2 times, most recently
from
8df917e to
bf42c9c
Compare
|
To better understand how this could be used I've also created a OpenStack CMS plugin and test skeleton here: fnordahl@9e254e9 |
To ensure contributors make use of the projects formatting preferences we create a top level `pyproject.toml` file with configuration for the black Python code formatter. Signed-off-by: Frode Nordahl <[email protected]>
The explicit reference to type in calls to super() are no longer necessary as of Python 3 [0]. 0: https://docs.python.org/3/library/functions.html#super Signed-off-by: Frode Nordahl <[email protected]>
Move CMS specific test bringup code out of `ovn_tester` module. Introduce `cms_name` global config. Load cms specific module and class on the back of name from configuration. Convert the `base_cluster_bringup` step to a regular test step. Signed-off-by: Frode Nordahl <[email protected]>
The test cases in `ovn-tester/tests` are all CMS specific. Now that we have CMS plugins, relocate the test code along with them. Signed-off-by: Frode Nordahl <[email protected]>
fnordahl
force-pushed
the
ovn-workload-extract-generic
branch
3 times, most recently
from
bf7cf15 to
d66ea2f
Compare
Signed-off-by: Frode Nordahl <[email protected]>
Signed-off-by: Frode Nordahl <[email protected]>
Signed-off-by: Frode Nordahl <[email protected]>
fnordahl
force-pushed
the
ovn-workload-extract-generic
branch
from
d66ea2f to
ad28530
Compare
Merged
|
The patches from this PR has been carried over to #179, let's review them there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR depends on and includes commits from #173