Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cluster bringup. #180

Merged
merged 8 commits into from
Oct 4, 2023
Merged

Refactor cluster bringup. #180

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3bb9c69
ovn-tester: Remove unused mgmt_net fields.
dceara Sep 28, 2023
5a97782
treewide: Use cluster_cfg instead of cluster_config.
dceara Sep 28, 2023
87e6653
ovn-tester: Store a copy of the mgmt IP when creating new nodes.
dceara Sep 28, 2023
ec0a73c
ovn-tester: Fix WorkerNode mgmt IP allocation.
dceara Sep 28, 2023
348028a
ovn-tester: Add explicit RelayNode class.
dceara Sep 27, 2023
55928fa
ovn_tester: Make the CentralNode instance handle a single DB container.
dceara Sep 27, 2023
82809c8
ovn_tester: Factor out protocol as member of Node.
dceara Sep 28, 2023
1380bba
ovn-tester: Use Cluster instead of central + worker tuples.
dceara Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ovn-tester/ovn_workload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class Node(ovn_sandbox.Sandbox):
def __init__(self, phys_node, container, mgmt_ip):
super().__init__(phys_node, container)
self.container = container
self.mgmt_ip = mgmt_ip
self.mgmt_ip = netaddr.IPAddress(mgmt_ip)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the concern here that other parts of the code might change mgmt_ip value? Because looking at the docs, the IPAddress object looks pretty immutable. (Just curious here)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's exactly it. I was doing something like that while trying out @LorenzoBianconi's ovn-ic changes, using a netaddr.IPAddress externally through iterate through node IPs and ending up changing all the ones that were already assigned.



class CentralNode(Node):
Expand Down