Add error handling #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a bit more work, but it's a start. Seeing how the travis-ci job run looks now. |
| @@ -4,6 +4,9 @@ | |||
| XTRACE=$(set +o | grep xtrace) | |||
| set -o xtrace | |||
|
|
|||
| # Track failures | |||
| FAILED=0 | |||
There was a problem hiding this comment.
Is this variable used to indicate how many tests the CI job fails?
There was a problem hiding this comment.
It's mainly used to detect if a specific command in docker-rally.sh fails. If run fails, we want to ensure we run cleanup, but we need to remember run failed so we can return that to travis-ci. Make sense?
Add some initial error handling into the CI scripts Closes Issue ovn-org#69 Signed-off-by: Kyle Mestery <[email protected]>
|
@mestery is the PR ready for review or more to add? Thanks. |
|
@huikang I think so, I plan to add more error backout in the other scripts, but this can merge as-is now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some initial error handling into the CI scripts
Closes Issue #69
Signed-off-by: Kyle Mestery [email protected]