Validation improvements #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mbenguig
reviewed
Feb 28, 2025
sal-service/src/main/java/org/ow2/proactive/sal/service/service/ClusterService.java
Show resolved
Hide resolved
mbenguig
reviewed
Feb 28, 2025
sal-service/src/main/java/org/ow2/proactive/sal/service/service/ClusterService.java
Show resolved
Hide resolved
mbenguig
reviewed
Feb 28, 2025
sal-service/src/main/java/org/ow2/proactive/sal/service/util/RMConnectionHelper.java
Show resolved
Hide resolved
mbenguig
reviewed
Feb 28, 2025
sal-service/src/main/java/org/ow2/proactive/sal/service/util/RMConnectionHelper.java
Show resolved
Hide resolved
mbenguig
reviewed
Feb 28, 2025
| @@ -41,7 +41,7 @@ public static void init(String url) { | |||
| * @return The initialized Scheduler gateway | |||
| */ | |||
| public static synchronized RestSmartProxyImpl connect(String username, String password) { | |||
| LOGGER.debug("Connecting to Scheduler ..."); | |||
| //LOGGER.debug("Connecting to Scheduler ..."); | |||
There was a problem hiding this comment.
commenting logs regarding connection renewal due to fact it creates too many logs in pods due to automatic renewals
mbenguig
reviewed
Feb 28, 2025
sal-service/src/main/java/org/ow2/proactive/sal/service/util/SchedulerConnectionHelper.java
Show resolved
Hide resolved
fviale
pushed a commit
that referenced
this pull request
Mar 3, 2025
* introduce verification for cloud and cluster name * introduce verification for cluster nodes on definition * scaleout validation * omitting logs for connection renewal (cherry picked from commit 1392df6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introducing validation of
commenting logs regarding connection renewal due to fact it creates too many logs in pods due to automatic renewals