-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added OpenLDAP and Keycloak to the full config #10020
base: master
Are you sure you want to change the base?
Conversation
Added OpenLDAP and Keycloak to the full config as it is realisitically the most probably way to be deployed.
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
I really have no idea what I am doing. I just mashed the keyboard to get here. |
Ldap service updated
Windows deleted the eicar file. I accidentally commited the change too. |
Quality Gate passedIssues Measures |
@@ -203,9 +203,27 @@ WOPISERVER_ONLYOFFICE_DOMAIN= | |||
# Domain for Inbucket. Defaults to "mail.owncloud.test". | |||
INBUCKET_DOMAIN= | |||
|
|||
### LDAP server settings ### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is openldap (openldap.yml), name it openldap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can do, I just cut and paste from
ocis/deployments/examples/ocis_ldap/.env
Line 31 in 0fa0c5e
### LDAP server settings ### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let's try to not duplicate the LDIF files within the repository. They'll get out of sync the next time we need to change something in the LDAP Schema. How about moving these files into a high level directory and using that from ocis_ldap
and ocis_full
.
(Same is true for the 10_base.ldif
.
Added OpenLDAP and Keycloak to the full config as it is realisitically the most probably way to be deployed.
I am not sure if OpenLDAP and keycloak should be merged into a single config as I have set this up with NO default users or groups in LDAP as they are pulled in via Keycloak and auto provisioning.