Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] add test to share project drive's resource to a federated user #10264

Merged
merged 1 commit into from
Oct 22, 2024
Merged

[tests-only][full-ci] add test to share project drive's resource to a federated user #10264

merged 1 commit into from
Oct 22, 2024

Conversation

prashant-gurung899
Copy link
Contributor

@prashant-gurung899 prashant-gurung899 commented Oct 8, 2024 •
edited
Loading

Description

This PR adds ocm test to check activities of a resource from personal drive shared to a federated user.

Scenario: local user shares resources from project space to federation user

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@prashant-gurung899 prashant-gurung899 self-assigned this Oct 8, 2024
@prashant-gurung899 prashant-gurung899 mentioned this pull request Oct 8, 2024
Open
24 tasks
@prashant-gurung899 prashant-gurung899 changed the title [tests-only][full-ci] add test to activities of personal drive's resource shared to a federated user [tests-only][full-ci] add test to check activities of project drive's resource shared to a federated user Oct 14, 2024
@prashant-gurung899 prashant-gurung899 marked this pull request as ready for review October 15, 2024 05:43
@prashant-gurung899 prashant-gurung899 changed the title [tests-only][full-ci] add test to check activities of project drive's resource shared to a federated user [tests-only][full-ci] add test to share project drive's resource to a federated user Oct 21, 2024
@amrita-shrestha
Copy link
Contributor

@saw-jan why test scenario have multiple when for ocm. Any specific reason. Because it seems out of our current practice

amrita-shrestha
amrita-shrestha requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please look for spelling error in

Feature: an user shares resources usin ScienceMesh application

saw-jan
saw-jan reviewed Oct 22, 2024
View reviewed changes
tests/acceptance/features/apiOcm/share.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiOcm/share.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiOcm/share.feature Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

saw-jan
saw-jan approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@saw-jan
Copy link
Member

saw-jan commented Oct 22, 2024

@saw-jan why test scenario have multiple when for ocm. Any specific reason. Because it seems out of our current practice

In some cases, it should be fine unless you misuse it. It is always good to have atomic test scenarios but we also have to consider the growing number of tests
Multiple When can be refactored into Given, Then but in the coming PRs

@prashant-gurung899 prashant-gurung899 merged commit 10bf7f1 into master Oct 22, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Oct 22, 2024
@prashant-gurung899
Merge pull request #10264 from owncloud/tests-ocm
fcc5285 
[tests-only][full-ci] add test to share project drive's resource to a federated user
@prashant-gurung899 prashant-gurung899 deleted the tests-ocm branch October 22, 2024 09:32
@prashant-gurung899 prashant-gurung899 mentioned this pull request Nov 22, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrita-shrestha amrita-shrestha amrita-shrestha approved these changes

@saw-jan saw-jan saw-jan approved these changes

@ishabaral ishabaral Awaiting requested review from ishabaral

@SagarGi SagarGi Awaiting requested review from SagarGi

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@anon-pradip anon-pradip Awaiting requested review from anon-pradip

Assignees

@prashant-gurung899 prashant-gurung899

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prashant-gurung899 @amrita-shrestha @saw-jan @anon-pradip @nirajacharya2