Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a WatchMountPoint variable, events are considered relative to it #10519

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add a WatchMountPoint variable, events are considered relative to it #10519

wants to merge 2 commits into from

Conversation

aduffeck
Copy link
Contributor

@aduffeck aduffeck commented Nov 8, 2024

Add a WatchMountPoint option to posixfs which allows for prefixing filesystem events with a mountpath.

@update-docs Update Docs
Copy link

update-docs bot commented Nov 8, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

mmattel
mmattel requested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@mmattel mmattel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

introductionVersion must be fixed, see comment.

UPDATE: done

services/storage-users/pkg/config/config.go Outdated Show resolved Hide resolved
@aduffeck aduffeck mentioned this pull request Nov 8, 2024
Draft
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

kwdrago
kwdrago approved these changes Nov 12, 2024
View reviewed changes
Copy link

@kwdrago kwdrago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't this setting be derived out of the Space-Template variables? In the sense of reducing environment vars...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmattel mmattel mmattel requested changes

@kwdrago kwdrago kwdrago approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aduffeck @mmattel @kwdrago