[tests-only][full-ci] refactor: Set chunking version 1 as default #10624
Conversation
anon-pradip
force-pushed
the
set-chunking-version
branch
from
b069f78 to
9c95a8d
Compare
anon-pradip
requested review from
saw-jan,
PrajwolAmatya,
ishabaral,
prashant-gurung899,
amrita-shrestha and
nirajacharya2
anon-pradip
changed the title
anon-pradip
force-pushed
the
set-chunking-version
branch
4 times, most recently
from
706ba6f to
535bbaf
Compare
anon-pradip
requested review from
nirajacharya2,
PrajwolAmatya,
amrita-shrestha,
saw-jan and
S-Panta
anon-pradip
force-pushed
the
set-chunking-version
branch
from
535bbaf to
483a649
Compare
anon-pradip
force-pushed
the
set-chunking-version
branch
2 times, most recently
from
c351546 to
b171fbb
Compare
anon-pradip
force-pushed
the
set-chunking-version
branch
2 times, most recently
from
09a1979 to
73a01af
Compare
| } | ||
|
|
||
| //prepare chunking |
There was a problem hiding this comment.
what was done in this preparation?
| //prepare chunking | |
| //prepare chunking |
There was a problem hiding this comment.
$chunk → Returns array of file chunks(source file split into multiple chunks)
$chunkingId → Generates random identifier (e.g., "chunking-4567") and groups related chunks together
$result → Initializes variable to store upload response which will be updated during chunk upload process
| Given using <dav-path-version> DAV path | ||
| When user "Alice" uploads file "filesForUpload/davtest.txt" to filenames based on "/davtest.txt" with all mechanisms except new chunking using the WebDAV API | ||
| And user "Alice" uploads file "filesForUpload/davtest.txt" to filenames based on "/davtest.txt" with all mechanisms except new chunking using the WebDAV API | ||
| When user "Alice" uploads file "filesForUpload/davtest.txt" to "davtest.txt" with and without chunking using the WebDAV API |
There was a problem hiding this comment.
why uploading with and without at once?
| When user "Alice" uploads file "filesForUpload/davtest.txt" to "davtest.txt" with and without chunking using the WebDAV API | |
| When user "Alice" uploads file "filesForUpload/davtest.txt" to "davtest.txt" with and without chunking using the WebDAV API |
There was a problem hiding this comment.
Scenario Outline: upload a file twice and versions are available using various chunking methods
There was a problem hiding this comment.
actual scenario: #10624 (comment)
| ); | ||
| } | ||
| foreach ([false, true] as $chunkingUse) { | ||
| $finalDestination = $overwriteMode ? $destination : $destination . ($chunkingUse ? "-chunked" : ""); |
There was a problem hiding this comment.
AFAIK, we should not need this.
| $finalDestination = $overwriteMode ? $destination : $destination . ($chunkingUse ? "-chunked" : ""); |
There was a problem hiding this comment.
If we use $destination directly as param in upload():
First upload (non-chunked):
- Path: davtest.txt
- Creates file: davtest.txt
Second upload (chunked):
- Temporary chunks: davtest.txt-chunking-4320-2-0, davtest.txt-chunking-4320-2-1
- Final assembled file: davtest.txt (overwrites original)
- Creates version because of overwrite
which makes the test fail for the step:
Then the version folder of file "davtest.txt" for user "Alice" should contain "0" elements
But if we use something like $finalDestination:
First upload (non-chunked):
- Path: davtest.txt
- Creates file: davtest.txt
Second upload (chunked):
- Temporary chunks: davtest.txt-chunked-chunking-8951-2-0, davtest.txt-chunked-chunking-8951-2-1
- Final assembled file: davtest.txt-chunked
- No version created because files are separate
There was a problem hiding this comment.
if the mentioned step fails, we have to look at what is happening and maybe scenario is not clear.
as per the scenario, I thought the the different upload methods to create same file will not creat file versions.
There was a problem hiding this comment.
After having closer look together with @saw-jan:
- refactored the scenarios from:
Scenario Outline: upload file and no version is available using various chunking methods (except new chunking),
Scenario Outline: upload a file twice and versions are available using various chunking methods (except new chunking)to:
Scenario Outline: no version is available while uploading a file with multiple chunks
Scenario Outline: versions are available while uploading a file twice with multiple chunksrespectively for providing more clear sense.
- removed
uploadWithAllMechanismsas it will be unused. - changed return types to
ResponseInterfacefor consistency and better error handling.
anon-pradip
force-pushed
the
set-chunking-version
branch
from
73a01af to
d9e2092
Compare
anon-pradip
force-pushed
the
set-chunking-version
branch
from
d9e2092 to
9f189d9
Compare
anon-pradip
force-pushed
the
set-chunking-version
branch
from
9f189d9 to
e4a8365
Compare
|
[tests-only][full-ci] refactor: Set chunking version 1 as default
[tests-only][full-ci] refactor: Set chunking version 1 as default
Description
This PR removes the
chunkingToUsevariable from the code-base which in turn makes the use of existing TUS chunk upload endpoint by default.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: