Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] add tests to download thumbnail preview of a federated share image #10651

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

prashant-gurung899
Copy link
Contributor

Description

This PR adds test to download thumbnail preview of a federated shared image.

Scenario: local user downloads thumbnail preview of a federated shared image

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-download-preview branch 2 times, most recently from a4275bc to 9639b22 Compare November 26, 2024 11:53
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use this previous step. Because it is not very good to hide the important details of a request/action

When user "Alice" downloads the preview of federated share image "testavatar.jpg" with width "32" and height "32" and processor "thumbnail" using the WebDAV API

but you can remove processor "thumbnail" from the step or even do not request with processor param. It can always be thumbnail (default)

tests/acceptance/features/apiOcm/share.feature Outdated Show resolved Hide resolved
tests/acceptance/fixtures/federated-share-thumbnail.png Outdated Show resolved Hide resolved
@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-download-preview branch 2 times, most recently from e6c90be to fa26b6a Compare November 27, 2024 04:24
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others looks 👍

tests/acceptance/bootstrap/WebDav.php Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 27, 2024

@saw-jan saw-jan merged commit e4778ec into master Nov 27, 2024
4 checks passed
@saw-jan saw-jan deleted the tests-ocm-download-preview branch November 27, 2024 08:18
ownclouders pushed a commit that referenced this pull request Nov 27, 2024
[tests-only][full-ci] add tests to download thumbnail preview of a federated share image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants