[tests-only][full-ci]added test to list shares sharedWithMe after the share role has been disabled #10744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
PrajwolAmatya
force-pushed
the
enable-disable-share-roles
branch
4 times, most recently
from
44f524c to
965e458
Compare
9 tasks
PrajwolAmatya
force-pushed
the
enable-disable-share-roles
branch
2 times, most recently
from
09dc702 to
9e86da7
Compare
PrajwolAmatya
requested review from
anon-pradip,
ishabaral,
SagarGi,
saw-jan,
prashant-gurung899,
Salipa-Gurung,
amrita-shrestha,
nabim777,
S-Panta and
nirajacharya2
PrajwolAmatya
force-pushed
the
enable-disable-share-roles
branch
4 times, most recently
from
9f3adf0 to
4c4acae
Compare
saw-jan
reviewed
Dec 23, 2024
PrajwolAmatya
force-pushed
the
enable-disable-share-roles
branch
from
4c4acae to
992e2c4
Compare
amrita-shrestha
requested changes
Dec 24, 2024
PrajwolAmatya
force-pushed
the
enable-disable-share-roles
branch
from
992e2c4 to
d91dff6
Compare
PrajwolAmatya
changed the title
tests/acceptance/features/apiSharingNg1/enableDisablePermissionsRole.feature
Outdated
Show resolved
Hide resolved
PrajwolAmatya
force-pushed
the
enable-disable-share-roles
branch
from
d91dff6 to
9e9671e
Compare
PrajwolAmatya
force-pushed
the
enable-disable-share-roles
branch
from
9e9671e to
0345f21
Compare
|
saw-jan
reviewed
Dec 30, 2024
Comment on lines
+14
to
+16
| Scenario Outline: users list the shares shared with Secure Viewer after the role is disabled (Personal Space) | ||
| Given the administrator has enabled the permissions role "Secure Viewer" | ||
| And user "Alice" has uploaded file with content "some content" to "textfile.txt" |
There was a problem hiding this comment.
maybe we should assert these in a single scenario for these kinds of tests (edge-cases):
- sharedByMe (sharer)
- sharedWithMe (sharee)
- list me/drives (sharee)
- PROPFIND Shares space (sharee)
- some action by sharee (e.g.: download file)
There was a problem hiding this comment.
I have updated the changes in the follow up PR #10756. We can merge this PR and add these changes in other PR.
saw-jan
approved these changes
Dec 31, 2024
amrita-shrestha
approved these changes
Dec 31, 2024
ownclouders
pushed a commit
that referenced
this pull request
Dec 31, 2024
[tests-only][full-ci]added test to list shares sharedWithMe after the share role has been disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the test to list shares
sharedWithMeafter the share role has been disabled, with preconditionenable role->share->disable roleRelated Issue
Types of changes
Checklist: