Fix nats reconnects #8880
Merged
Fix nats reconnects #8880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jkoberg <[email protected]>
rhafer
requested changes
Apr 18, 2024
| natsOptions.ReconnectedCB = func(_ *nats.Conn) { | ||
| if err := n.Init(); err != nil { | ||
| fmt.Println("cannot reconnect to nats") | ||
| os.Exit(1) |
There was a problem hiding this comment.
💥 OUCH
I guess I understand why you're doing that. And I don't have a better solution at hand. But I still feel the need to say: This is ugly 😄
Would be nice if we could find a way for a more graceful error handling here.
There was a problem hiding this comment.
Yes I 100% agree. ❤️ I'll fix it as soon as we have a proper solution.
rhafer
approved these changes
Apr 18, 2024
Co-authored-by: Ralf Haferkamp <[email protected]> Signed-off-by: jkoberg <[email protected]>
|
|
No code changes - just force pushed to restart sonarcloud. |
|
@micbar Why do think it could be problematic regarding semver? It's a bugfix. It doesn't need new config. Neither does it break existing setups (does it?). |
|
then let us backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repairs reconnects on the natsjs kv registry
New behaviour:
Fixes #8783