Skip to content

Commit

Permalink
fix(editor/vscode): set minimum supported ver. to ^1.93.0 (#8182)
Browse files Browse the repository at this point in the history
Hi,

I'm using Cursor which is based on VSCode `1.93` at the moment of this
PR. And i've faced with an issue when i can't install latest version of
oxc vscode plugin - by default plugin marketplace offers me `v0.0.1` and
via `Install Specific Version` i can install only `v0.10.3` while latest
is `v0.15.3`. No idea when Cursor will update its version.
There's no issue with VSCode, only Cursor.

After downgrading minimum version, Cursor allowed me to install plugin
that i compiled by myself, everything seem to be working.

Not sure about how is usually contributions made here so correct me if i
miss something
  • Loading branch information
pashokitsme authored Dec 30, 2024
1 parent 47cea9a commit 0794bee
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 10 deletions.
5 changes: 2 additions & 3 deletions .github/renovate.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": ["github>Boshen/renovate", "helpers:pinGitHubActionDigests"],
"ignorePaths": [
"crates/oxc_linter/fixtures/**"
]
"ignorePaths": ["crates/oxc_linter/fixtures/**"],
"ignoreDeps": ["@types/vscode"]
}
4 changes: 2 additions & 2 deletions editors/vscode/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"oxc"
],
"engines": {
"vscode": "^1.96.0"
"vscode": "^1.93.0"
},
"sponsor": {
"url": "https://github.com/sponsors/boshen"
Expand Down Expand Up @@ -146,7 +146,7 @@
"devDependencies": {
"@types/mocha": "^10.0.9",
"@types/node": "^22.0.0",
"@types/vscode": "1.96.0",
"@types/vscode": "1.93.0",
"@vscode/test-cli": "^0.0.10",
"@vscode/test-electron": "^2.4.1",
"@vscode/vsce": "^3.0.0",
Expand Down
10 changes: 5 additions & 5 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 0794bee

Please sign in to comment.