Skip to content

Commit

Permalink
ci: Passthrough OXC_VERSION and JEMALLOC_SYS_WITH_LG_PAGE to build co…
Browse files Browse the repository at this point in the history
…ntainer (#5531)

Fixes:
- #4891

Currently only Mac OS and Windows versions return correct version. Linux
versions still returns `dev`. This is caused by Mac OS and Windows
building on the host
([logs](https://github.com/oxc-project/oxc/actions/runs/10667173657/job/29564299213#step:6:16)),
while Linux is building inside a container. Container builds do not have
access to host env variables by default.
  • Loading branch information
valeneiko authored Sep 6, 2024
1 parent ff88c1f commit 80d80b7
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion Cross.toml
Original file line number Diff line number Diff line change
@@ -1,2 +1,6 @@
[build.env]
passthrough = ["CI"] # for crates/oxc_traverse/build.rs
passthrough = [
"CI", # for crates/oxc_traverse/build.rs
"OXC_VERSION",
"JEMALLOC_SYS_WITH_LG_PAGE",
]

0 comments on commit 80d80b7

Please sign in to comment.