Skip to content

Commit

Permalink
feat(linter): change react/rules-of-hooks category to pedantic (#…
Browse files Browse the repository at this point in the history
…7691)

Although this rule is recommended by the React team,
it does not report incorrect or wrong code for the `correctness` category.

When turned on by default, I find false positive warnings confusing,
I cannot tell whether my code is wrong or the rule implementation is
wrong - see examples in the affine repo.

```
  x eslint-plugin-react-hooks(rules-of-hooks): React Hook "use" cannot be called at the top level. React Hooks must be called in a React function component or a custom React Hook function.
    ,-[packages/backend/server/src/config/affine.self.ts:80:1]
 79 |     /* Captcha Plugin Default Config */
 80 | ,-> AFFiNE.use('captcha', {
 81 | |     turnstile: {},
 82 | |     challenge: {
 83 | |       bits: 20,
 84 | |     },
 85 | `-> });
 86 |
    `----
```
  • Loading branch information
Boshen committed Dec 6, 2024
1 parent 7cee065 commit fd0935c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion crates/oxc_linter/src/rules/react/rules_of_hooks.rs
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ declare_oxc_lint!(
/// <https://reactjs.org/docs/hooks-rules.html>
///
RulesOfHooks,
correctness
pedantic
);

impl Rule for RulesOfHooks {
Expand Down

0 comments on commit fd0935c

Please sign in to comment.