Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(formatter,linter,codegen): remove oxc_formatter #1968

Merged
merged 1 commit into from
Jan 10, 2024
Merged

refactor(formatter,linter,codegen): remove oxc_formatter #1968

merged 1 commit into from
Jan 10, 2024

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jan 9, 2024

closes #1941

@Boshen Graphite App
Copy link
Member Author

Boshen commented Jan 9, 2024 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added A-linter Area - Linter A-codegen Area - Code Generation labels Jan 9, 2024
@Boshen Boshen marked this pull request as draft January 9, 2024 13:22
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 9, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1968 will degrade performances by 6.48%

Comparing 01-09-refactor_formatter_linter_codegen_remove_oxc_formatter (800ac7a) with main (b5f4f1e)

Summary

❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 01-09-refactor_formatter_linter_codegen_remove_oxc_formatter Change
❌ semantic[pdf.mjs] 113.2 ms 121 ms -6.48%

@Boshen Boshen force-pushed the 01-09-refactor_formatter_linter_codegen_remove_oxc_formatter branch from 2bf3c0b to 0410ce5 Compare January 10, 2024 06:28
@Boshen Boshen marked this pull request as ready for review January 10, 2024 06:28
@Boshen Boshen force-pushed the 01-09-refactor_formatter_linter_codegen_remove_oxc_formatter branch from 0410ce5 to 800ac7a Compare January 10, 2024 06:38
@Boshen Boshen enabled auto-merge (squash) January 10, 2024 06:38
@Boshen Boshen merged commit a6717db into main Jan 10, 2024
18 checks passed
@Boshen Boshen deleted the 01-09-refactor_formatter_linter_codegen_remove_oxc_formatter branch January 10, 2024 06:41
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
@Boshen @IWANABETHATGUY
refactor(formatter,linter,codegen): remove oxc_formatter (oxc-project…
48411da 
…#1968)

closes oxc-project#1941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-codegen Area - Code Generation A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove oxc_formatter and replace linter fix with oxc_codegen
1 participant
@Boshen