Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default visitor should visit prop init at visit_object_property #2000

Merged
merged 1 commit into from
Jan 12, 2024
Merged

fix: default visitor should visit prop init at visit_object_property #2000

merged 1 commit into from
Jan 12, 2024

Conversation

underfin
Copy link
Contributor

The visit_object_property should visit prop.int node.

@github-actions github-actions bot added the A-ast Area - AST label Jan 12, 2024
@Boshen Boshen merged commit 0d77e1e into oxc-project:main Jan 12, 2024
16 checks passed
@underfin underfin deleted the visit_object_property-init branch January 12, 2024 05:43
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 12, 2024

CodSpeed Performance Report

Merging #2000 will not alter performance

Comparing underfin:visit_object_property-init (3116e3e) with main (6a7e4be)

Summary

✅ 14 untouched benchmarks

IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
@underfin @IWANABETHATGUY
fix: default visitor should visit prop init at visit_object_property (
5e7f822 
oxc-project#2000)

The `visit_object_property` should visit `prop.int` node.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-ast Area - AST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@underfin @Boshen