Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transformer/typescript): remove import if only have type reference #2001

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 12, 2024

No description provided.

@Dunqing
Copy link
Member Author

Dunqing commented Jan 12, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler labels Jan 12, 2024
Copy link

codspeed-hq bot commented Jan 12, 2024

CodSpeed Performance Report

Merging #2001 will not alter performance

Comparing 01-12-feat_transformer/typescript_remove_import_if_only_have_type_reference (b12ff61) with main (b386177)

Summary

✅ 14 untouched benchmarks

@Boshen
Copy link
Member

Boshen commented Jan 12, 2024

This overlaps with the symbol "Type" definition, let's discuss about this.

const TypeAlias = 1 << 9;
const Interface = 1 << 10;
const RegularEnum = 1 << 11;
const ConstEnum = 1 << 12;
const EnumMember = 1 << 13;
const TypeLiteral = 1 << 14;
const TypeParameter = 1 << 15;
const NameSpaceModule = 1 << 16;
const ValueModule = 1 << 17;

@Dunqing Dunqing marked this pull request as draft January 12, 2024 14:47
@Boshen Boshen marked this pull request as ready for review January 13, 2024 08:47
@Boshen Boshen force-pushed the 01-12-feat_transformer/typescript_remove_import_if_only_have_type_reference branch from 7f58926 to b12ff61 Compare January 13, 2024 08:48
@Boshen Boshen enabled auto-merge (squash) January 13, 2024 08:51
@Boshen Boshen merged commit ead4e8d into main Jan 13, 2024
18 checks passed
@Boshen Boshen deleted the 01-12-feat_transformer/typescript_remove_import_if_only_have_type_reference branch January 13, 2024 08:52
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants