Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): eslint-plugin-jsx-a11y aria-activedescendant-has-tabindex #2012

Merged
merged 2 commits into from
Jan 14, 2024
Merged

feat(linter): eslint-plugin-jsx-a11y aria-activedescendant-has-tabindex #2012

merged 2 commits into from
Jan 14, 2024

Conversation

keita-hino
Copy link
Contributor

@github-actions github-actions bot added the A-linter Area - Linter label Jan 13, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 13, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2012 will not alter performance

Comparing keita-hino:aria-activedescendant-has-tabindex (de5111e) with main (04540f7)

Summary

✅ 14 untouched benchmarks

@keita-hino keita-hino force-pushed the aria-activedescendant-has-tabindex branch from 6f7a095 to ad8b0cb Compare January 13, 2024 09:59
camc314
camc314 approved these changes Jan 14, 2024
View reviewed changes
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@camc314 camc314 merged commit 198f0e5 into oxc-project:main Jan 14, 2024
16 checks passed
@camc314 camc314 mentioned this pull request Jan 16, 2024
Open
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
@keita-hino @IWANABETHATGUY
feat(linter): eslint-plugin-jsx-a11y aria-activedescendant-has-tabind…
408abb9 
…ex (oxc-project#2012)

Part of: oxc-project#1141

Based on:
- docs: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/aria-activedescendant-has-tabindex.md
- code: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/src/rules/aria-activedescendant-has-tabindex.js
- test: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/__tests__/src/rules/aria-activedescendant-has-tabindex-test.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 camc314 approved these changes

Assignees
No one assigned
Labels
A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keita-hino @camc314