Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(parser): hint that end of file only happens once #2026

Closed
wants to merge 1 commit into from

Conversation

overlookmotel
Copy link
Contributor

Hint to branch predictor that lexer only gets to end of the file once.

I doubt this will actually make any difference. Just posting to see what Codspeed says.

@github-actions github-actions bot added the A-parser Area - Parser label Jan 14, 2024
@overlookmotel
Copy link
Contributor Author

Benchmark timed out downloading antd.js. Happened 3 times, but appears unrelated to content of this PR.

@overlookmotel
Copy link
Contributor Author

overlookmotel commented Jan 14, 2024

Ah no sorry, it was my fault. There was an infinite loop in my code. Fixed now.

@overlookmotel overlookmotel changed the title perf(parser): hint that end of file once happens once perf(parser): hint that end of file only happens once Jan 14, 2024
Copy link

codspeed-hq bot commented Jan 14, 2024

CodSpeed Performance Report

Merging #2026 will not alter performance

Comparing overlookmotel:lexer-bytes2 (eb7ad07) with main (198f0e5)

Summary

✅ 14 untouched benchmarks

@overlookmotel
Copy link
Contributor Author

Well after all that, the change makes no difference whatsoever!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-parser Area - Parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant