Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vscode): allow config path configuration #2172

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

Djiit
Copy link
Contributor

@Djiit Djiit commented Jan 25, 2024

Fixes #1944

@shevernitskiy
Copy link

shevernitskiy commented Jan 25, 2024

Could it handle all of the possible default config names?

.eslintrc
.eslintrc.js
.eslintrc.cjs
.eslintrc.yaml
.eslintrc.yml
.eslintrc.json
package.json

@Djiit
Copy link
Contributor Author

Djiit commented Jan 25, 2024

Yes, but not in this PR, because in the end oxlint still expect a JSON format. Happy to revisit this when the core linter is able to parse more versions of it (including maybe the new config version).

@Djiit
Copy link
Contributor Author

Djiit commented Jan 25, 2024

@Boshen first try here. I could even keep the old code as a fallback, and remove the configuartion default. e.g. "if vscode configuration is empty, try .eslintrc and .eslintrc.json" wdyt?

@Boshen Boshen requested a review from IWANABETHATGUY January 26, 2024 02:02
@Boshen Boshen marked this pull request as ready for review January 26, 2024 02:02
Copy link

codspeed-hq bot commented Jan 26, 2024

CodSpeed Performance Report

Merging #2172 will not alter performance

Comparing Djiit:allow-vscode-extension-config-path (cdf4fb5) with main (fc1592b)

Summary

✅ 17 untouched benchmarks

@Boshen Boshen merged commit d5b378a into oxc-project:main Jan 26, 2024
17 checks passed
@Djiit Djiit deleted the allow-vscode-extension-config-path branch January 26, 2024 08:22
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support configuring the config file path from vscode settings.
3 participants