feat(semantic): report parameter related errors for setter/getter

[Dunqing]

No description provided.

[Dunqing]

Current dependencies on/for this PR:

• main
  • PR feat(semantic): report type parameter list cannot be empty #2315
    • PR feat(semantic): report parameter related errors for setter/getter #2316 👈
      • PR feat(ast): enter AstKind::ExportDefaultDeclaration, AstKind::ExportNamedDeclaration and AstKind::ExportAllDeclaration #2317

This stack of pull requests is managed by Graphite.

[codspeed-hq]

CodSpeed Performance Report

Merging #2316 will not alter performance

_{Comparing 02-05-feat_semantic_report_parameter_related_errors_for_set_accessor (e2bcd8d) with main (9ca13d0)}

Summary

✅ 27 untouched benchmarks

[Boshen]

This is a javascript error with a missing case from

oxc/crates/oxc_parser/src/js/class.rs

Lines 364 to 380 in a762d17

	if kind == MethodDefinitionKind::Get && value.params.parameters_count() != 0 {
	self.error(diagnostics::GetterParameters(value.params.span));
	}
	if kind == MethodDefinitionKind::Set && value.params.parameters_count() != 1 {
	self.error(diagnostics::SetterParameters(value.params.span));
	}
	if kind == MethodDefinitionKind::Constructor {
	if let Some(this_param) = &value.this_param {
	// class Foo { constructor(this: number) {} }
	self.error(diagnostics::TSConstructorThisParameter(this_param.span));
	}
	if r#static {
	self.error(diagnostics::StaticConstructor(key.span()));
	}

I think it's easier to move these checks over to checker/javascript.js instead of keeping them in the parser?

[Dunqing]

This is a javascript error with a missing case from

oxc/crates/oxc_parser/src/js/class.rs

Lines 364 to 380 in a762d17

	if kind == MethodDefinitionKind::Get && value.params.parameters_count() != 0 {
	self.error(diagnostics::GetterParameters(value.params.span));
	}
	if kind == MethodDefinitionKind::Set && value.params.parameters_count() != 1 {
	self.error(diagnostics::SetterParameters(value.params.span));
	}
	if kind == MethodDefinitionKind::Constructor {
	if let Some(this_param) = &value.this_param {
	// class Foo { constructor(this: number) {} }
	self.error(diagnostics::TSConstructorThisParameter(this_param.span));
	}
	if r#static {
	self.error(diagnostics::StaticConstructor(key.span()));
	}

I think it's easier to move these checks over to checker/javascript.js instead of keeping them in the parser?

Yes, I will move the implementation to checker/javascript.js

[Boshen]

Merge activity

• Feb 5, 4:38 AM EST: @Boshen started a stack merge that includes this pull request via Graphite.
• Feb 5, 4:38 AM EST: @Boshen merged this pull request with Graphite.