Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): don't parse null as a literal type #2572

Merged
merged 1 commit into from
Mar 3, 2024
Merged

fix(parser): don't parse null as a literal type #2572

merged 1 commit into from
Mar 3, 2024

Conversation

ArnaudBarre
Copy link
Contributor

See playgrounds:

@github-actions github-actions bot added the A-parser Area - Parser label Mar 2, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 2, 2024

CodSpeed Performance Report

Merging #2572 will not alter performance

Comparing ArnaudBarre:null-type (1d6d3d8) with main (ad8ca2a)

Summary

✅ 27 untouched benchmarks

@Boshen Boshen merged commit 8a81851 into oxc-project:main Mar 3, 2024
21 checks passed
@ArnaudBarre ArnaudBarre deleted the null-type branch March 3, 2024 12:03
a-rustacean pushed a commit to a-rustacean/oxc that referenced this pull request Mar 4, 2024
@ArnaudBarre @a-rustacean
fix(parser): don't parse null as a literal type (oxc-project#2572)
f9d34e2 
See playgrounds:

-
[oxc](https://oxc-project.github.io/oxc/playground/?code=3YCAAIDbgICAgICAgIC6nsrEgteLFrCnQnPuEizmC%2BDQ8C8bP9fXPj%2B7%2FjjmRZPvpAH3N7PfIPDu7RDOlrl79cHiork8WA08r39%2FqpCAgA%3D%3D)
-
[Babel](https://astexplorer.net/#/gist/9f43cf0fe91760e11f1572934681c92f/3a263be55bc89804aac7cf89a756d60111313136)
a-rustacean added a commit to a-rustacean/oxc that referenced this pull request Mar 4, 2024
@a-rustacean
Revert "fix(parser): don't parse null as a literal type (oxc-project#…
156b92d 
…2572)"

This reverts commit f9d34e2.
a-rustacean added a commit to a-rustacean/oxc that referenced this pull request Mar 4, 2024
@a-rustacean
Revert "fix(parser): don't parse null as a literal type (oxc-project#…
bdfe844 
…2572)"

This reverts commit f9d34e2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-parser Area - Parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArnaudBarre @Boshen