Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(parser): make sure all span.end >= span.start #2681

Merged
merged 2 commits into from
Mar 11, 2024
Merged

chore(parser): make sure all span.end >= span.start #2681

merged 2 commits into from
Mar 11, 2024

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Mar 11, 2024

closes #2679

@Boshen Graphite App
Copy link
Member Author

Boshen commented Mar 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-parser Area - Parser label Mar 11, 2024
@Boshen Boshen force-pushed the 03-11-chore_parser_make_sure_all_span.end_span.start branch from d48697d to f65742f Compare March 11, 2024 10:51
@Boshen
Copy link
Member Author

Boshen commented Mar 11, 2024

Ahhh ... I should've done this sooner

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 11, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2681 will not alter performance

Comparing 03-11-chore_parser_make_sure_all_span.end_span.start (f8f5873) with main (75ae563)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen force-pushed the 03-11-chore_parser_make_sure_all_span.end_span.start branch from f65742f to 619d13c Compare March 11, 2024 11:19
@Boshen Boshen force-pushed the 03-11-chore_parser_make_sure_all_span.end_span.start branch from 619d13c to 60fc61d Compare March 11, 2024 11:22
@Boshen Boshen merged commit 8a73d18 into main Mar 11, 2024
24 checks passed
@Boshen Boshen deleted the 03-11-chore_parser_make_sure_all_span.end_span.start branch March 11, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-parser Area - Parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(parser): make sure all span.end >= span.start
1 participant
@Boshen