Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lint): split files for no_side_effects rule #2684

Merged
merged 1 commit into from
Mar 12, 2024
Merged

refactor(lint): split files for no_side_effects rule #2684

merged 1 commit into from
Mar 12, 2024

Conversation

mysteryven
Copy link
Contributor

No description provided.

@mysteryven Graphite App
Copy link
Contributor Author

mysteryven commented Mar 11, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mysteryven and the rest of your teammates on Graphite Graphite

@mysteryven mysteryven mentioned this pull request Mar 11, 2024
Merged
@github-actions github-actions bot added the A-linter Area - Linter label Mar 11, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 11, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2684 will not alter performance

Comparing 03-11-refactor_lint_split_files_for_no_side_effects_rule (4c2c35a) with main (3ae9479)

Summary

✅ 29 untouched benchmarks

@Boshen Graphite App
Copy link
Member

Boshen commented Mar 12, 2024 •
edited
Loading

Merge activity

  • Mar 11, 11:04 PM EDT: @Boshen started a stack merge that includes this pull request via Graphite.
  • Mar 11, 11:05 PM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 11, 11:09 PM EDT: @Boshen merged this pull request with Graphite.

Base automatically changed from 03-11-feat_linter_report_side_effect_for_array_element to main March 12, 2024 03:04
@Boshen Boshen force-pushed the 03-11-refactor_lint_split_files_for_no_side_effects_rule branch from 5279ca8 to 4c2c35a Compare March 12, 2024 03:04
@Boshen Boshen merged commit 220eba1 into main Mar 12, 2024
22 checks passed
@Boshen Boshen deleted the 03-11-refactor_lint_split_files_for_no_side_effects_rule branch March 12, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mysteryven @Boshen