feat(transformer): implement @babel/plugin-transform-react-jsx-self #2846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fireairforce
commented
Mar 28, 2024
| @@ -202,6 +201,10 @@ impl<'a> VisitMut<'a> for Transformer<'a> { | |||
| self.decorators.as_mut().map(|t| t.transform_declaration(decl)); | |||
| } | |||
|
|
|||
| fn visit_jsx_opening_element(&mut self, elem: &mut JSXOpeningElement<'a>) { | |||
There was a problem hiding this comment.
it seems that visit_jsx_opening_element will execute after visit_expression, so the jsx_self transformer will execute after react_jsx transformer, maybe i need to move self.jsx_self.as_mut().map(|t| t.transform_jsx_opening_element(elem)); into visit_expression ?
fireairforce
force-pushed
the
support-transform-react-jsx-self
branch
from
0b6e4ff to
005d12e
Compare
fireairforce
force-pushed
the
support-transform-react-jsx-self
branch
from
005d12e to
e988491
Compare
CodSpeed Performance ReportMerging #2846 will degrade performances by 3.12%Comparing Summary
Benchmarks breakdown
|
|
Thank you for working on this. I copied your implementation and merged them in #2946 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement: https://babeljs.io/docs/babel-plugin-transform-react-jsx-self