feat(linter): eslint/max-len

[woai3c]

No description provided.

[mysteryven]

Change it to draft because of not ready yet. 😉

[woai3c]

Change it to draft because of not ready yet. 😉

Okay, I'm currently preparing for a job search and I don't have much time. I'm sorry.

[mysteryven]

If you are busy but still want to contribute to our repo, this issue may more suitable for you than this rule.🤔

[woai3c]

If you are busy but still want to contribute to our repo, this issue may more suitable for you than this rule.🤔

If you are busy but still want to contribute to our repo, this issue may more suitable for you than this rule.🤔

Thank you very much for your reply. I really want to contribute to the code, so thank you. I closed this PR because I found that the workload involved is quite large, and there are some issues I don't understand and can't find someone to solve, so I want to close it first. When I was implementing the max-len rule, I encountered two problems: 1. The fn from_configuration() method that each rule has should merge the default values and the configuration values, but I can't find where it is executed. 2. It is necessary to use AST to parse the code, such as determining comments. Can I directly use the AST of oxc to scan here?

[woai3c]

If you are busy but still want to contribute to our repo, this issue may more suitable for you than this rule.🤔

I'm going to check out the issue you mentioned now.

[woai3c]

If you are busy but still want to contribute to our repo, this issue may more suitable for you than this rule.🤔

If you are busy but still want to contribute to our repo, this issue may more suitable for you than this rule.🤔

Thank you very much for your reply. I really want to contribute to the code, so thank you. I closed this PR because I found that the workload involved is quite large, and there are some issues I don't understand and can't find someone to solve, so I want to close it first. When I was implementing the max-len rule, I encountered two problems:

1. The fn from_configuration() method that each rule has should merge the default values and the configuration values, but I can't find where it is executed.
2. It is necessary to use AST to parse the code, such as determining comments. Can I directly use the AST of oxc to scan here?

[mysteryven]

I'm going to check out the issue you mentioned now.

Are you working on it now? The author of this rule(@todor-a) is also planning to do it. My bad, I should have confirmed it first.

[todor-a]

I'm going to check out the issue you mentioned now.

Are you working on it now? The author of this rule(@todor-a) is also planning to do it. My bad, I should have confirmed it first.

Haven't gotten too far. If you have feel free to finish it!

[woai3c]

I'm going to check out the issue you mentioned now.

Are you working on it now? The author of this rule(@todor-a) is also planning to do it. My bad, I should have confirmed it first.

I haven't started yet, so I'll continue researching max len.

[woai3c]

I'm going to check out the issue you mentioned now.

Are you working on it now? The author of this rule(@todor-a) is also planning to do it. My bad, I should have confirmed it first.

Haven't gotten too far. If you have feel free to finish it!

I haven't started yet, so I'll continue researching max len.

[mysteryven]

1. The fn from_configuration() method that each rule has should merge the default values and the configuration values, but I can't find where it is executed.

Are you looking for this?

1. oxc/crates/oxc_linter/src/config/mod.rs

   Lines 99 to 100 in 8662f4f

   	rules_to_replace.push(rule.read_json(rule_config.config.clone()));
   	}

2. oxc/crates/oxc_macros/src/declare_all_lint_rules/mod.rs

   Lines 101 to 107 in 8662f4f

   	pub fn read_json(&self, maybe_value: Option<serde_json::Value>) -> Self {
   	match self {
   	#(Self::#struct_names(_) => Self::#struct_names(
   	maybe_value.map(#struct_names::from_configuration).unwrap_or_default(),
   	)),*
   	}
   	}

It is necessary to use AST to parse the code, such as determining comments. Can I directly use the AST of oxc to scan here?

What's specific problem are you facing?

[woai3c]

1. The fn from_configuration() method that each rule has should merge the default values and the configuration values, but I can't find where it is executed.

Are you looking for this?

1. oxc/crates/oxc_linter/src/config/mod.rs

   Lines 99 to 100 in 8662f4f

   	rules_to_replace.push(rule.read_json(rule_config.config.clone()));
   	}

2. oxc/crates/oxc_macros/src/declare_all_lint_rules/mod.rs

   Lines 101 to 107 in 8662f4f

   	pub fn read_json(&self, maybe_value: Option<serde_json::Value>) -> Self {
   	match self {
   	#(Self::#struct_names(_) => Self::#struct_names(
   	maybe_value.map(#struct_names::from_configuration).unwrap_or_default(),
   	)),*
   	}
   	}

It is necessary to use AST to parse the code, such as determining comments. Can I directly use the AST of oxc to scan here?

What's specific problem are you facing?

Thank you for the response. My previous question was about understanding where this rule receives user option values from.

[mysteryven]

where this rule receives user option values from.

oxc/crates/oxc_linter/src/options.rs

Line 226 in 63b4741

config.override_rules(&mut rules, &all_rules);

then it call:

oxc/crates/oxc_linter/src/config/mod.rs

Line 99 in 63b4741

rules_to_replace.push(rule.read_json(rule_config.config.clone()));

The config of this rule are in rule_config.config

rule_config.config are parsing from config file:

oxc/crates/oxc_linter/src/config/rules.rs

Line 51 in 63b4741

let (severity, config) = parse_rule_value(&value).map_err(de::Error::custom)?;

[woai3c]

@mysteryven Hi, I have passed all the eslint tests regarding max-len, except for JSX. I'm not sure how to implement it for JSX yet, as the current AST in oxc seems unable to read JSX comments. I need to think about how to approach this. If you have any good suggestions, feel free to advise.

[mysteryven]

It's a really nice work! I need some time to take a close look at it, will give you feedback tomorrow.

[woai3c]

It's a really nice work! I need some time to take a close look at it, will give you feedback tomorrow.

Thank you for your response. If I have some free time in the next few days, I will try to add support for JSX.

[codspeed-hq]

CodSpeed Performance Report

Merging #2874 will degrade performances by 8.42%

_{Comparing woai3c:main (e72520f) with main (3f9f467)}

Summary

❌ 5 regressions
✅ 25 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	main	woai3c:main	Change
❌	linter[RadixUIAdoptionSection.jsx]	7.2 ms	7.5 ms	-4.09%
❌	linter[antd.js]	10 s	10.9 s	-7.91%
❌	linter[cal.com.tsx]	2.8 s	3 s	-5.76%
❌	linter[checker.ts]	5.1 s	5.6 s	-8.42%
❌	linter[pdf.mjs]	1.8 s	1.9 s	-4.83%

[mysteryven]

You can run just ready in your local to fix the Clippy error.

[woai3c]

@mysteryven Are there any other tasks I can work on? If not, I will check if there are any additional rules I can add for ESLint or Prettier.

[mysteryven]

I will check if there are any additional rules I can add for ESLint or Prettier.

Try a new ESLint rule or any issue you like!

---

I think we need to solve the performance issue, it decreases a bit large, I'll help to check the reason when I free.(usually at night :<), do you have discord account, you can add me mysteryven, let's discuss it!

[woai3c]

I will check if there are any additional rules I can add for ESLint or Prettier.

Try a new ESLint rule or any issue you like!

I think we need to solve the performance issue, it decreases a bit large, I'll help to check the reason when I free.(usually at night :<), do you have discord account, you can add me mysteryven, let's discuss it!

Ok, I have sent a friend request.

[mysteryven]

I changed the category to style, let's merge it first.