Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(semantic/jsdoc): Handle optional type syntax for type name part #2960

Merged
merged 6 commits into from
Apr 15, 2024
Merged

feat(semantic/jsdoc): Handle optional type syntax for type name part #2960

merged 6 commits into from
Apr 15, 2024

Conversation

leaysgur
Copy link
Contributor

It seems JSDocTypeNamePart can contain whitespace like...

/** @property [cfg.n12="default value"] Config... */

@github-actions github-actions bot added the A-semantic Area - Semantic label Apr 13, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 13, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2960 will improve performances by 3.38%

Comparing jsdoc-optional-type-name (f58b3f0) with main (5a286c3)

Summary

⚡ 1 improvements
✅ 29 untouched benchmarks

Benchmarks breakdown

Benchmark main jsdoc-optional-type-name Change
⚡ semantic[cal.com.tsx] 231.8 ms 224.3 ms +3.38%

@leaysgur leaysgur marked this pull request as ready for review April 15, 2024 02:12
@Boshen Boshen merged commit 40af2b1 into main Apr 15, 2024
30 checks passed
@Boshen Boshen deleted the jsdoc-optional-type-name branch April 15, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen approved these changes

Assignees
No one assigned
Labels
A-semantic Area - Semantic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leaysgur @Boshen