Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transform_conformance): drop all babel 7 specific tests #2982

Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Apr 14, 2024

@Dunqing Is this correct?

Copy link
Member Author

Boshen commented Apr 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Apr 14, 2024
@Boshen Boshen requested a review from Dunqing April 14, 2024 14:51
Copy link

codspeed-hq bot commented Apr 14, 2024

CodSpeed Performance Report

Merging #2982 will not alter performance

Comparing 04-14-feat_transform_conformance_drop_all_babel_7_specific_tests (c7e4f25) with main (c753c9f)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen merged commit 9643cba into main Apr 14, 2024
32 checks passed
@Boshen Boshen deleted the 04-14-feat_transform_conformance_drop_all_babel_7_specific_tests branch April 14, 2024 15:02
@Dunqing
Copy link
Member

Dunqing commented Apr 15, 2024

I think we don't need to drop all babel 7 tests. Because babel 8 doesn't break these tests. We just need to skip all "BABEL_8_BREAKING": true tests. (That's how it's done now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants