Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(transformer_conformance): skip plugins we don't support yet #2988

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Apr 15, 2024

We don't need PLUGINS_NOT_SUPPORTED_YET. The PLUGINS are the plugins we supported.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Apr 15, 2024
Copy link
Member Author

Dunqing commented Apr 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@Dunqing Dunqing marked this pull request as ready for review April 15, 2024 02:02
Copy link

codspeed-hq bot commented Apr 15, 2024

CodSpeed Performance Report

Merging #2988 will not alter performance

Comparing 04-15-refactor_transformer_conformance_skip_plugins_we_don_t_support_yet (3ae5723) with main (5a286c3)

Summary

✅ 30 untouched benchmarks

@Boshen
Copy link
Member

Boshen commented Apr 15, 2024

I think it's nicer to know which plugins we should work on next. I'll close this.

@Boshen Boshen closed this Apr 15, 2024
@Boshen Boshen deleted the 04-15-refactor_transformer_conformance_skip_plugins_we_don_t_support_yet branch August 12, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants