refactor(transformer/typescript): remove all code that removes ts annotations

[Dunqing]

As #2951 (comment) said. oxc_codegen will not print all typescript-only code. So removing ts annotations is redundant

[Dunqing]

• refactor(transformer/typescript): remove all code that removes ts annotations #2992 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #2992 will degrade performances by 3.26%

_{Comparing 04-15-refactor_transformer_typescript_remove_all_code_that_removes_ts_annotations (00772cb) with main (82e00bc)}

Summary

❌ 1 regressions
✅ 29 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	main	04-15-refactor_transformer_typescript_remove_all_code_that_removes_ts_annotations	Change
❌	semantic[antd.js]	737.9 ms	762.8 ms	-3.26%

[Boshen]

Wait ... this is still useful for downstream tools if they want to work with esnext ast.

Sorry for the confusion.

[Dunqing]

Wait ... this is still useful for downstream tools if they want to work with esnext ast.

Can you give examples of how this works downstream?

[Boshen]

Wait ... this is still useful for downstream tools if they want to work with esnext ast.

Can you give examples of how this works downstream?

AST -> transformer -> (third party tools working on esnext syntax) -> codegen

[Dunqing]

AST -> transformer -> (third party tools working on esnext syntax) -> codegen

The third party still use oxc_codegen, so whether or not the transformer removes typescript annotation does not affect third party tools. Am I understanding right?

[Boshen]

Another note: subsequent runs don't need to visit these extra nodes anymore, which can be a lot.

[Dunqing]

Another note: subsequent runs don't need to visit these extra nodes anymore, which can be a lot.

Yes, indeed