perf(ast): box ImportDeclarationSpecifier enum variants
#3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-parser
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
CodSpeed Performance ReportMerging #3061 will not alter performanceComparing Summary
|
Boshen
approved these changes
Apr 22, 2024
Boshen
deleted the
04-21-perf_ast_box_ImportDeclarationSpecifier_enum_variants
branch
Boshen
pushed a commit
that referenced
this pull request
Apr 22, 2024
Similar to #3058 and #3061 it is a continuation of #3047. Handles these enum types: > TSEnumMemberName > Variant sizes: 16, 24, 24, 40 > Unboxed variants: IdentifierName (struct), StringLiteral (struct), NumericLiteral (struct) > Dependents: TSEnumMember (struct) > => Box all variants. > > TSModuleReference > Variant sizes: 16, 32 > Unboxed variants: TSExternalModuleReference (struct) > Dependents: Box<TSModuleReference> in TSImportEqualsDeclaration > => Box all variants. Replace Box<TSModuleReference> with TSModuleReference in TSImportEqualsDeclaration. > > TSTypePredicateName > Variant sizes: 8, 24 > Unboxed variants: IdentifierName (struct), TSThisType (struct) > Dependents: TSTypePredicate (struct) > => Box Identifier variant. Do not box This variant as only 8 bytes (just contains Span). > > TSTypeQueryExprName > Variant sizes: 16, 88 > Unboxed variants: TSImportType (struct) > Dependents: TSTypeQuery (struct) > => Box TSImportType variant. Do not box TSTypeName variant, as is another enum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3047.
As with #3058, it's hard to interpret the benchmark results here. But in this case I think it's easier to see from "first principles" that this should be an improvement -
ImportSpecifieris pretty massive (80 bytes) vsImportDefaultSpecifier(40 bytes), and the latter (e.g.import React from 'react') is common in JS code.