feat(transform): oxc_traverse crate
#3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #3169 will not alter performanceComparing Summary
|
mysteryven
reviewed
May 8, 2024
| @@ -0,0 +1,149 @@ | |||
| //! AST traversal with ability to read up the tree from visitors. | |||
| //! | |||
| //! Please see [`traverse_mut`] for an explanation of API. | |||
There was a problem hiding this comment.
These documents explain things really really good! I should read your PRs one by one, they are all treasures.
There was a problem hiding this comment.
That's incredibly kind of you to say. Thank you.
I do think it's important to write lengthy comments to explain how things work. But I'm a native English speaker, so I have an advantage in that respect - it's quite easy for me to turn thoughts into English words.
If you find anything where the comments don't make sense, or don't fully explain what the code is doing, or why, please do alert me and I'll do my best to improve them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #3152.
This adds a crate
oxc_traverse, but doesn't connect it up to the transformer or anything else yet.I think we could merge this now - as it doesn't affect any code that's in use - and then iterate on it to add scopes before using it in transformer. Please see #3152 (comment) for the broader picture.