Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transform): implement transform-react-display-name with bottom-up lookup #3183

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented May 6, 2024

Sliced off from #3152.

Re-implement transform-react-display-name using bottom-up lookup provided by Traverse trait.

This fixes the 1 remaining failing test case for this plugin (see #2937).

Traverse is not complete yet (see #3182), so this is also not ready to merge yet.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label May 6, 2024
Copy link
Contributor Author

overlookmotel commented May 6, 2024

Copy link

codspeed-hq bot commented May 6, 2024

CodSpeed Performance Report

Merging #3183 will not alter performance

Comparing 05-06-fix_transform_implement_transform-react-display-name_with_bottom-up_lookup (ca433e6) with main (15f275f)

Summary

✅ 27 untouched benchmarks

Base automatically changed from 05-06-refactor_transform_transformer_use_Traverse_ to main May 8, 2024 09:18
@Boshen Boshen marked this pull request as ready for review May 8, 2024 10:14
@Boshen Boshen requested a review from Dunqing May 8, 2024 10:14
@Dunqing Dunqing enabled auto-merge (squash) May 8, 2024 11:45
@Dunqing
Copy link
Member

Dunqing commented May 8, 2024

Need to fix conflict

@overlookmotel overlookmotel force-pushed the 05-06-fix_transform_implement_transform-react-display-name_with_bottom-up_lookup branch from 4d2779e to ca433e6 Compare May 8, 2024 15:30
@Dunqing Dunqing merged commit 9590eb0 into main May 8, 2024
18 checks passed
@Dunqing Dunqing deleted the 05-06-fix_transform_implement_transform-react-display-name_with_bottom-up_lookup branch May 8, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants