fix(ast, ast_codegen): use generate_derive instead of visitable for generating span derives.
#4747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #4747 will not alter performanceComparing Summary
|
rzvxa
force-pushed
the
08-08-refactor_ast_codegen_declutter_the_main_file
branch
from
cf28242 to
850ff38
Compare
rzvxa
force-pushed
the
08-08-fix_ast_ast_codegen_use_generate_derive_instead_of_visitable_for_generating_span_derives
branch
from
cf10b69 to
98a2260
Compare
rzvxa
force-pushed
the
08-08-refactor_ast_codegen_declutter_the_main_file
branch
from
850ff38 to
eead990
Compare
rzvxa
force-pushed
the
08-08-fix_ast_ast_codegen_use_generate_derive_instead_of_visitable_for_generating_span_derives
branch
from
98a2260 to
8440cdf
Compare
rzvxa
force-pushed
the
08-08-refactor_ast_codegen_declutter_the_main_file
branch
from
eead990 to
9a94c20
Compare
rzvxa
force-pushed
the
08-08-fix_ast_ast_codegen_use_generate_derive_instead_of_visitable_for_generating_span_derives
branch
from
8440cdf to
862fe61
Compare
overlookmotel
changed the base branch from
08-08-refactor_ast_codegen_declutter_the_main_file
to
graphite-base/4747
overlookmotel
force-pushed
the
08-08-fix_ast_ast_codegen_use_generate_derive_instead_of_visitable_for_generating_span_derives
branch
from
862fe61 to
60b6cf9
Compare
overlookmotel
approved these changes
Aug 8, 2024
Merge activity
|
overlookmotel
force-pushed
the
08-08-fix_ast_ast_codegen_use_generate_derive_instead_of_visitable_for_generating_span_derives
branch
from
60b6cf9 to
e711be3
Compare
|
CI got stuck again. Have force pushed the branch with no changes just to unstick it. @rzvxa FYI. I don't know if this is Graphite playing up again, but same thing happened on the "cursed" stack of last night too. |
overlookmotel
force-pushed
the
08-08-fix_ast_ast_codegen_use_generate_derive_instead_of_visitable_for_generating_span_derives
branch
from
e711be3 to
fff9da3
Compare
graphite-app
bot
deleted the
08-08-fix_ast_ast_codegen_use_generate_derive_instead_of_visitable_for_generating_span_derives
branch
Merged
Boshen
added a commit
that referenced
this pull request
Aug 10, 2024
## [0.24.1] - 2024-08-10 ### Features - b3c3125 linter: Overhaul unicorn/no-useless-spread (#4791) (DonIsaac) - c519295 minifier: Add `InjectGlobalVariables` plugin (`@rollup/plugin-inject`) (#4759) (Boshen) ### Bug Fixes - fff9da3 ast, ast_codegen: Use `generate_derive` instead of visitable for generating span derives. (#4747) (rzvxa) - f5eeebd ast_macros: Raise compile error on invalid `generate_derive` input. (#4766) (rzvxa) - 4d0b40a napi/transform: Fix wrong isolated declarations emit (Boshen) ### Refactor - daa0b2e ast: `oxc_ast` crate re-export AST types from other crates (#4773) (overlookmotel) - d4a3be8 ast_codegen: Line breaks between types in layout assertions (#4781) (overlookmotel) - dbb5f4c ast_codegen: Remove unnecessary imports from generated files (#4774) (overlookmotel) - 7ea058d ast_codegen: Replace Windows-style line breaks with Unix-style (#4769) (overlookmotel) - 2dea0ca ast_codegen: Consistent import order (#4761) (overlookmotel) Co-authored-by: Boshen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #4735
I was accidentally using the old code to filter the viable target types to derive. It means before this PR we were still using the
#[ast(visit)]for this purpose.