Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(transformer): Optional Chaining #6990

Merged
merged 1 commit into from
Nov 21, 2024
Merged

feat(transformer): Optional Chaining #6990

merged 1 commit into from
Nov 21, 2024

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Oct 29, 2024 •
edited by Dunqing
Loading

close: #6958

@graphite-app Graphite App
Copy link

graphite-app bot commented Oct 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Oct 29, 2024
@Boshen Boshen force-pushed the optional-chaining branch from 7809900 to a49a4e2 Compare October 29, 2024 07:05
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 29, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #6990 will degrade performances by 7.84%

Comparing optional-chaining (885e37f) with main (8cebdc8)

Summary

❌ 3 regressions
✅ 27 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main optional-chaining Change
❌ transformer[cal.com.tsx] 32.7 ms 33.9 ms -3.49%
❌ transformer[checker.ts] 17.7 ms 18.8 ms -5.64%
❌ transformer[pdf.mjs] 6.5 ms 7 ms -7.84%

@Boshen Boshen force-pushed the optional-chaining branch from a49a4e2 to 6259ab5 Compare October 29, 2024 07:25
@Dunqing Graphite App
Copy link
Member

Dunqing commented Nov 6, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the A-ast Area - AST label Nov 12, 2024
@Dunqing Dunqing changed the base branch from main to 11-17-feat_transformer_support_generate_proper_binding_name_from_chainexpression November 17, 2024 09:17
This was referenced Nov 17, 2024
Merged
Merged
@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser A-semantic Area - Semantic A-cli Area - CLI A-minifier Area - Minifier A-codegen Area - Code Generation A-prettier Area - Prettier A-isolated-declarations Isolated Declarations A-ast-tools Area - AST tools A-editor Area - Editor and Language Server labels Nov 17, 2024
@Dunqing Dunqing changed the base branch from 11-17-feat_transformer_support_generate_proper_binding_name_from_chainexpression to main November 18, 2024 03:03
@Dunqing Dunqing changed the base branch from main to 11-17-feat_transformer_support_generate_proper_binding_name_from_chainexpression November 18, 2024 03:05
@Dunqing Dunqing force-pushed the optional-chaining branch 2 times, most recently from 96d4a43 to 86d462e Compare November 18, 2024 03:11
@Boshen Boshen force-pushed the graphite-base/6990 branch from 2762481 to 6cfb5df Compare November 19, 2024 10:40
@Boshen Boshen changed the base branch from graphite-base/6990 to main November 19, 2024 10:40
@Dunqing Dunqing removed C-enhancement Category - New feature or request A-linter Area - Linter A-parser Area - Parser A-semantic Area - Semantic A-cli Area - CLI A-minifier Area - Minifier A-codegen Area - Code Generation A-prettier Area - Prettier A-isolated-declarations Isolated Declarations A-ast-tools Area - AST tools A-editor Area - Editor and Language Server labels Nov 20, 2024
@Dunqing
Copy link
Member

Dunqing commented Nov 20, 2024

The semantic errors are related to #7355.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Nov 20, 2024
@Dunqing Dunqing marked this pull request as ready for review November 21, 2024 01:57
Dunqing
Dunqing approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@Dunqing Dunqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Nov 21, 2024
@Dunqing Graphite App
Copy link
Member

Dunqing commented Nov 21, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 20, 10:11 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 20, 10:11 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 20, 10:17 PM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot merged commit 885e37f into main Nov 21, 2024
27 checks passed
@graphite-app graphite-app bot deleted the optional-chaining branch November 21, 2024 03:17
@oxc-bot oxc-bot mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dunqing Dunqing Dunqing approved these changes

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

transformer: OptionalChain
2 participants
@Boshen @Dunqing