Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(doc): replace main/master to tag/commit to make the url always accessible #7298

Merged

Conversation

ShuiRuTian
Copy link
Contributor

@ShuiRuTian ShuiRuTian commented Nov 15, 2024

Fix #7291

The match relationship is :

 {
    "oxc-project/oxc": "main",
    "cvazac/eslint-plugin-react-perf": "9bfa930661a23218f5460ebd39d35d76ccdb5724",
    "DefinitelyTyped/DefinitelyTyped": "b5dc32740d9b45d11cff9b025896dd333c795b39",
    "estree/estree": "e6015c4c63118634749001b1cd1c3f7a0388f16e",
    "fregante/eslint-formatters": "ae1fd9748596447d1fd09625c33d9e7ba9a3d06d",
    "javascript-compiler-hints/compiler-notations-spec": "c14f7e197cb225c9eee877143536665ce3150712",
    "mozilla-spidermonkey/jsparagus": "24004745a8ed4939fc0dc7332bfd1268ac52285f",
    "privatenumber/minification-benchmarks": "d8d54ceeb206d318fa288b152904adf715b076b2",
    "tc39/source-map": "1930e58ffabefe54038f7455759042c6e3dd590e",
    "tc39/test262": "05c45a4c430ab6fee3e0c7f0d47d8a30d8876a6d",
    "biomejs/biome": "cli/v1.9.4",
    "eslint-community/eslint-plugin-promise": "v7.1.0",
    "eslint-community/eslint-plugin-n": "v17.13.2",
    "rollup/plugins": "pluginutils-v5.1.3",
    "rome/tools": "lsp/v0.28.0",
    "A11yance/aria-query": "v5.3.2",
    "babel/babel": "v7.26.2",
    "denoland/deno_graph": "0.84.0",
    "eslint/eslint": "v9.9.1",
    "evanw/esbuild": "v0.24.0",
    "facebook/react": "v18.3.1",
    "gajus/eslint-plugin-jsdoc": "v50.5.0",
    "getsentry/rust-sourcemap": "9.1.0",
    "google/closure-compiler": "v20240609",
    "guybedford/es-module-lexer": "1.5.4",
    "import-js/eslint-plugin-import": "v2.29.1",
    "jest-community/eslint-plugin-jest": "v28.9.0",
    "jsx-eslint/eslint-plugin-jsx-a11y": "v6.9.0",
    "jsx-eslint/eslint-plugin-react": "v7.37.2",
    "Kilian/electron-to-chromium": "v1.5.60",
    "lukastaegert/eslint-plugin-tree-shaking": "v1.12.2",
    "microsoft/TypeScript": "v5.6.3",
    "nicolo-ribaudo/babel": "v7.25.8",
    "nodevault/node-vault": "v0.10.2",
    "prettier/prettier": "3.3.3",
    "ratel-rust/ratel-core": "v0.7.0",
    "rolldown-rs/rolldown": "v0.14.0",
    "rust-lang/rust": "1.82.0",
    "sindresorhus/eslint-plugin-unicorn": "v56.0.0",
    "terser/terser": "v5.9.0",
    "typescript-eslint/typescript-eslint": "v8.9.0",
    "vercel/next.js": "v15.0.2",
    "veritem/eslint-plugin-vitest": "v1.1.9",
}

Copy link

graphite-app bot commented Nov 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser A-minifier Area - Minifier A-ast Area - AST A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation A-prettier Area - Prettier A-isolated-declarations Isolated Declarations A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 15, 2024
Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #7298 will not alter performance

Comparing ShuiRuTian:use-tag-or-commit-rather-than-main-for-url (b18dc74) with main (cf99be0)

Summary

✅ 30 untouched benchmarks

@Boshen
Copy link
Member

Boshen commented Nov 15, 2024

Errors in ./crates/oxc_prettier/README.md

@ShuiRuTian
Copy link
Contributor Author

ShuiRuTian commented Nov 16, 2024

Good catch, it's because the tag of following repo does not start with "v"

Write a script to ping the url and all should return 200 now.

@overlookmotel
Copy link
Contributor

overlookmotel commented Nov 16, 2024

Only one still failing: https://github.com/prettier/prettier/tree/v3.3.3/tests/format/js (the v shouldn't be there)

(see the "Check links" CI task)

@ShuiRuTian ShuiRuTian force-pushed the use-tag-or-commit-rather-than-main-for-url branch from 37ffc4c to b18dc74 Compare November 16, 2024 12:57
@ShuiRuTian
Copy link
Contributor Author

ShuiRuTian commented Nov 16, 2024

Only one still failing: https://github.com/prettier/prettier/tree/v3.3.3/tests/format/js (the v shouldn't be there)

(see the "Check links" CI task)

Thanks, it's actually because my force-push was failed on my local machine due to net issue.

I wrote a script to repalce url, so the easier way is to rewrote everything and make a force push

@Boshen Boshen merged commit cf3415b into oxc-project:main Nov 16, 2024
25 checks passed
@overlookmotel
Copy link
Contributor

Nice one! Thanks very much for doing this.

Dunqing pushed a commit that referenced this pull request Nov 17, 2024
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-ast-tools Area - AST tools A-codegen Area - Code Generation A-isolated-declarations Isolated Declarations A-linter Area - Linter A-minifier Area - Minifier A-parser Area - Parser A-prettier Area - Prettier A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc] the url of some file in some repo should have a specific commit or tag rather than branch
3 participants