Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data_structures): add methods to SparseStack #7305

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Nov 15, 2024

Add methods to SparseStack to get the filled entries as a slice, and get their length.

Copy link

graphite-app bot commented Nov 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Nov 15, 2024
@overlookmotel overlookmotel marked this pull request as ready for review November 15, 2024 21:08
Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #7305 will not alter performance

Comparing 11-15-feat_data_structures_add_methods_to_sparsestack_ (d135d3e) with main (1cbc624)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 16, 2024
Copy link
Member

Boshen commented Nov 16, 2024

Merge activity

  • Nov 16, 12:33 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 16, 12:33 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 16, 12:53 AM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 11-15-refactor_transformer_helper_load_methods_take_span_ branch from 9028609 to d13195c Compare November 16, 2024 05:34
Boshen pushed a commit that referenced this pull request Nov 16, 2024
Add methods to `SparseStack` to get the filled entries as a slice, and get their length.
@Boshen Boshen force-pushed the 11-15-feat_data_structures_add_methods_to_sparsestack_ branch from 4b3035a to b738fcc Compare November 16, 2024 05:34
Add methods to `SparseStack` to get the filled entries as a slice, and get their length.
@Boshen Boshen force-pushed the 11-15-refactor_transformer_helper_load_methods_take_span_ branch from d13195c to 4acf2db Compare November 16, 2024 05:37
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Nov 16, 2024
@Boshen Boshen force-pushed the 11-15-feat_data_structures_add_methods_to_sparsestack_ branch from b738fcc to d135d3e Compare November 16, 2024 05:37
Base automatically changed from 11-15-refactor_transformer_helper_load_methods_take_span_ to main November 16, 2024 05:49
@graphite-app graphite-app bot merged commit d135d3e into main Nov 16, 2024
29 checks passed
@graphite-app graphite-app bot deleted the 11-15-feat_data_structures_add_methods_to_sparsestack_ branch November 16, 2024 05:53
Dunqing pushed a commit that referenced this pull request Nov 17, 2024
Add methods to `SparseStack` to get the filled entries as a slice, and get their length.
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
Add methods to `SparseStack` to get the filled entries as a slice, and get their length.
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
Add methods to `SparseStack` to get the filled entries as a slice, and get their length.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants