Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(transformer/arrow-function): generate_super_binding_name take &str and &TraverseCtx #7310

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Nov 16, 2024

Pure refactor. Take &str rather than &Atom (1 less indirection) and &TraverseCtx<'a> (more conventional).

Copy link

graphite-app bot commented Nov 16, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Nov 16, 2024
Copy link

codspeed-hq bot commented Nov 16, 2024

CodSpeed Performance Report

Merging #7310 will not alter performance

Comparing 11-16-refactor_transformer_arrow-function_generate_super_binding_name_take_str_and_traversectx_ (5cfe0b6) with main (7d75130)

Summary

✅ 30 untouched benchmarks

Copy link
Member

Dunqing commented Nov 17, 2024

Merge activity

  • Nov 17, 12:01 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 17, 12:01 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 17, 12:15 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Test (ubuntu-latest)', 'Test (macos-14)', 'Clippy', 'Doc', 'Conformance', 'Test NAPI', 'Benchmark (lexer)', 'Benchmark (parser)', 'Benchmark (transformer)', 'Benchmark (isolated_declarations)', 'Benchmark (semantic)', 'Benchmark (minifier)', 'Benchmark (codegen)', 'Benchmark (sourcemap)', 'Check wasm32-unknown-unknown').
  • Nov 17, 5:16 AM EST: A user merged this pull request with the Graphite merge queue.

@Dunqing Dunqing changed the base branch from 11-11-feat_transformer_async-to-generator_arguments_isn_t_correct_after_transformation to graphite-base/7310 November 17, 2024 05:01
@graphite-app graphite-app bot changed the base branch from graphite-base/7310 to main November 17, 2024 05:07
@github-actions github-actions bot added the A-semantic Area - Semantic label Nov 17, 2024
Dunqing pushed a commit that referenced this pull request Nov 17, 2024
…ake `&str` and `&TraverseCtx` (#7310)

Pure refactor. Take `&str` rather than `&Atom` (1 less indirection) and `&TraverseCtx<'a>` (more conventional).
@Dunqing Dunqing force-pushed the 11-16-refactor_transformer_arrow-function_generate_super_binding_name_take_str_and_traversectx_ branch from 1c61f62 to a92521d Compare November 17, 2024 05:09
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 17, 2024
@Dunqing
Copy link
Member

Dunqing commented Nov 17, 2024

I don't know why this conflicted

@overlookmotel overlookmotel force-pushed the 11-16-refactor_transformer_arrow-function_generate_super_binding_name_take_str_and_traversectx_ branch from a92521d to 7fc8905 Compare November 17, 2024 10:01
overlookmotel added a commit that referenced this pull request Nov 17, 2024
…ake `&str` and `&TraverseCtx` (#7310)

Pure refactor. Take `&str` rather than `&Atom` (1 less indirection) and `&TraverseCtx<'a>` (more conventional).
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 17, 2024
…ake `&str` and `&TraverseCtx` (#7310)

Pure refactor. Take `&str` rather than `&Atom` (1 less indirection) and `&TraverseCtx<'a>` (more conventional).
@overlookmotel overlookmotel force-pushed the 11-16-refactor_transformer_arrow-function_generate_super_binding_name_take_str_and_traversectx_ branch from 7fc8905 to 5cfe0b6 Compare November 17, 2024 10:08
@graphite-app graphite-app bot merged commit 5cfe0b6 into main Nov 17, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 11-16-refactor_transformer_arrow-function_generate_super_binding_name_take_str_and_traversectx_ branch November 17, 2024 10:16
@overlookmotel
Copy link
Contributor Author

I don't know why this conflicted

Graphite mangled my PR! It seems to get confused sometimes when downstack PR has multiple commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants