Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transformer): remove typescript symbols after transformation #7330

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Nov 17, 2024

No description provided.

@Boshen Boshen requested a review from Dunqing November 17, 2024 12:56
Copy link

graphite-app bot commented Nov 17, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-bug Category - Bug labels Nov 17, 2024
@Boshen Boshen marked this pull request as draft November 17, 2024 12:59
Copy link

codspeed-hq bot commented Nov 17, 2024

CodSpeed Performance Report

Merging #7330 will degrade performances by 38.01%

Comparing 11-17-fix_transformer_remove_typescript_symbols_after_transformation (8b0c27d) with main (234c7b9)

Summary

❌ 2 regressions
✅ 28 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 11-17-fix_transformer_remove_typescript_symbols_after_transformation Change
transformer[cal.com.tsx] 32.6 ms 36.3 ms -10.11%
transformer[checker.ts] 17.7 ms 28.5 ms -38.01%

@Boshen Boshen force-pushed the 11-17-fix_transformer_remove_typescript_symbols_after_transformation branch from 35d21aa to 8661c0c Compare November 17, 2024 13:06
@Boshen Boshen force-pushed the 11-17-fix_transformer_remove_typescript_symbols_after_transformation branch from 8661c0c to 32e282b Compare November 20, 2024 04:34
@github-actions github-actions bot added the A-semantic Area - Semantic label Nov 20, 2024
@Boshen Boshen force-pushed the 11-17-fix_transformer_remove_typescript_symbols_after_transformation branch from 32e282b to 8b0c27d Compare November 20, 2024 06:11
@Boshen Boshen closed this Nov 26, 2024
@Boshen Boshen deleted the 11-17-fix_transformer_remove_typescript_symbols_after_transformation branch December 2, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant