Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): do not print parenthesis for in expression in ArrowFunctionExpression #7360

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Nov 19, 2024

Please check out esbuild

Copy link

graphite-app bot commented Nov 19, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@Dunqing Dunqing marked this pull request as ready for review November 19, 2024 14:09
@github-actions github-actions bot added A-codegen Area - Code Generation C-bug Category - Bug labels Nov 19, 2024
Copy link
Member Author

Dunqing commented Nov 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing changed the title fix(codegen): do not print parenthesis for in expression in ArrowFunctionExpression fix(codegen): do not print parenthesis for in expression in ArrowFunctionExpression Nov 19, 2024
@Dunqing Dunqing force-pushed the 11-19-fix_codegen_do_not_print_parenthesis_for_in_expression_in_arrowfunctionexpression branch from 3d182b6 to 25e18f1 Compare November 19, 2024 14:17
@Dunqing
Copy link
Member Author

Dunqing commented Nov 19, 2024

Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #7360 will not alter performance

Comparing 11-19-fix_codegen_do_not_print_parenthesis_for_in_expression_in_arrowfunctionexpression (c587dd3) with main (514878d)

Summary

✅ 30 untouched benchmarks

@Dunqing
Copy link
Member Author

Dunqing commented Nov 19, 2024

Executing https://github.com/oxc-project/monitor-oxc/actions/runs/11914971455

Only test262 failed and seems not related to this change

@Dunqing Dunqing requested a review from Boshen November 19, 2024 14:27
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 19, 2024
Copy link
Member

Boshen commented Nov 19, 2024

Merge activity

  • Nov 19, 9:28 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 19, 9:28 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 19, 9:35 AM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 11-19-fix_codegen_do_not_print_parenthesis_for_in_expression_in_arrowfunctionexpression branch from 25e18f1 to c587dd3 Compare November 19, 2024 14:29
@graphite-app graphite-app bot merged commit c587dd3 into main Nov 19, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 11-19-fix_codegen_do_not_print_parenthesis_for_in_expression_in_arrowfunctionexpression branch November 19, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-codegen Area - Code Generation C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants