Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(syntax): more comments for ReferenceFlags #7392

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Nov 21, 2024

Add more docs to ReferenceFlags, mainly to include the runtime test in #5165 (comment).

Copy link

graphite-app bot commented Nov 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-docs Category - Documentation. Related to user-facing or internal documentation label Nov 21, 2024
@overlookmotel overlookmotel marked this pull request as ready for review November 21, 2024 10:49
@overlookmotel overlookmotel requested a review from Boshen November 21, 2024 10:50
@overlookmotel overlookmotel force-pushed the 11-21-docs_syntax_more_comments_for_referenceflags_ branch from f4db3e2 to 90171b2 Compare November 21, 2024 10:52
Copy link

codspeed-hq bot commented Nov 21, 2024

CodSpeed Performance Report

Merging #7392 will not alter performance

Comparing 11-21-docs_syntax_more_comments_for_referenceflags_ (b3d5802) with main (a32f5a7)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 21, 2024
Copy link
Member

Boshen commented Nov 21, 2024

Merge activity

  • Nov 21, 6:16 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 21, 6:16 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 21, 6:25 AM EST: A user merged this pull request with the Graphite merge queue.

Boshen pushed a commit that referenced this pull request Nov 21, 2024
Add more docs to `ReferenceFlags`, mainly to include the runtime test in #5165 (comment).
@Boshen Boshen force-pushed the 11-21-docs_syntax_more_comments_for_referenceflags_ branch from 90171b2 to 2ecf71a Compare November 21, 2024 11:17
@overlookmotel overlookmotel force-pushed the 11-21-docs_syntax_more_comments_for_referenceflags_ branch from 2ecf71a to 39e8f01 Compare November 21, 2024 11:19
Add more docs to `ReferenceFlags`, mainly to include the runtime test in #5165 (comment).
@Boshen Boshen force-pushed the 11-21-docs_syntax_more_comments_for_referenceflags_ branch from 39e8f01 to b3d5802 Compare November 21, 2024 11:20
@graphite-app graphite-app bot merged commit b3d5802 into main Nov 21, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 11-21-docs_syntax_more_comments_for_referenceflags_ branch November 21, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue C-docs Category - Documentation. Related to user-facing or internal documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants